You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/02 02:02:40 UTC
[GitHub] [shardingsphere] marker-wu opened a new pull request, #19767: fix data node suffix pattern(#19423)
marker-wu opened a new pull request, #19767:
URL: https://github.com/apache/shardingsphere/pull/19767
Fixes #19423
Changes proposed in this pull request:
- fix data node suffix pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19767: fix data node suffix pattern(#19423)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19767:
URL: https://github.com/apache/shardingsphere/pull/19767#issuecomment-1201953082
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19767](https://codecov.io/gh/apache/shardingsphere/pull/19767?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e90df1f) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2e654172a58d9dc64da951d985be34dd776a5742?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e65417) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #19767 +/- ##
============================================
- Coverage 60.07% 60.06% -0.01%
Complexity 2399 2399
============================================
Files 3856 3856
Lines 54920 54920
Branches 7681 7681
============================================
- Hits 32993 32990 -3
- Misses 19098 19101 +3
Partials 2829 2829
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/shardingsphere/sharding/rule/TableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/19767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9UYWJsZVJ1bGUuamF2YQ==) | `82.40% <100.00%> (ø)` | |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/19767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #19767: fix data node suffix pattern(#19423)
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on PR #19767:
URL: https://github.com/apache/shardingsphere/pull/19767#issuecomment-1202212228
> @strongduanmu Any problem with my test case? If not, I'm ready to submit the code
@marker-wu You can submit the unit test, I will review this pr later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #19767: fix data node suffix pattern(#19423)
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #19767:
URL: https://github.com/apache/shardingsphere/pull/19767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] marker-wu commented on pull request #19767: fix data node suffix pattern(#19423)
Posted by GitBox <gi...@apache.org>.
marker-wu commented on PR #19767:
URL: https://github.com/apache/shardingsphere/pull/19767#issuecomment-1202075314
Any problem with my test case? If not, I'm ready to submit the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #19767: fix data node suffix pattern(#19423)
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on PR #19767:
URL: https://github.com/apache/shardingsphere/pull/19767#issuecomment-1201941501
@marker-wu Yes, we need to add some unit test in TableRuleTest for this new logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] marker-wu commented on pull request #19767: fix data node suffix pattern(#19423)
Posted by GitBox <gi...@apache.org>.
marker-wu commented on PR #19767:
URL: https://github.com/apache/shardingsphere/pull/19767#issuecomment-1201948696
> @marker-wu Yes, we need to add some unit test in TableRuleTest for this new logic.
is this OK？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] marker-wu commented on pull request #19767: fix data node suffix pattern(#19423)
Posted by GitBox <gi...@apache.org>.
marker-wu commented on PR #19767:
URL: https://github.com/apache/shardingsphere/pull/19767#issuecomment-1202214419
> > @strongduanmu Any problem with my test case? If not, I'm ready to submit the code
>
> @marker-wu You can submit the unit test, I will review this pr later.
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] marker-wu commented on pull request #19767: fix data node suffix pattern(#19423)
Posted by GitBox <gi...@apache.org>.
marker-wu commented on PR #19767:
URL: https://github.com/apache/shardingsphere/pull/19767#issuecomment-1201937704
>
> @marker-wu Can you add some unit test for this logic.
Add test case to the TableRuleTest class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org