You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2026/07/28 02:32:14 UTC
[PR] GH-50670: [Release][Dev]Fix only shellcheck SC2086 errors in the dev directory [arrow]
hiroyuki-sato opened a new pull request, #50671:
URL: https://github.com/apache/arrow/pull/50671
### Rationale for this change
This is the sub issue #44748.
Fix only ShellCheck SC2086 errors in the dev directory.
* SC2086: Double quote to prevent globbing and word splitting.
```
shellcheck dev/release/post-01-tag.sh
In dev/release/post-01-tag.sh line 34:
git tag -a ${release_tag} ${release_candidate_tag} -m "[Release] Apache Arrow Release ${version}"
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
git tag -a "${release_tag}" "${release_candidate_tag}" -m "[Release] Apache Arrow Release ${version}"
In dev/release/post-01-tag.sh line 35:
git push upstream ${release_tag}
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
git push upstream "${release_tag}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
```
### What changes are included in this PR?
* SC2086: Quote variables.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50670: [Release][Dev] Fix only shellcheck SC2086 errors in the dev directory [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #50671:
URL: https://github.com/apache/arrow/pull/50671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50670: [Release][Dev]Fix only shellcheck SC2086 errors in the dev directory [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50671:
URL: https://github.com/apache/arrow/pull/50671#issuecomment-5099304395
The remaining ShellCheck fixes in the ci directory are all R-related, and Iām waiting for the CI fixes.
In the meantime, I created this PR for the straightforward fixes in the dev directory.
Remaining files in the ci directory.
* ci/scripts/r_deps.sh: SC2006 SC2027 SC2086 SC2223
* ci/scripts/r_docker_configure.sh: SC2006 SC2046 SC2086 SC2223
* ci/scripts/r_install_system_dependencies.sh: SC2006 SC2223
* ci/scripts/r_sanitize.sh: SC2086 SC2155 SC2223
* ci/scripts/r_test.sh: SC1091 SC2086 SC2223
* ci/scripts/r_valgrind.sh: SC2046 SC2086 SC2223
* ci/scripts/r_windows_build.sh: SC2011 SC2034 SC2035 SC2046 SC2086 SC2155 SC2223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50670: [Release][Dev] Fix only shellcheck SC2086 errors in the dev directory [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50671:
URL: https://github.com/apache/arrow/pull/50671#issuecomment-5103272259
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 986641ff8f869256b4c57bd6d34ad06d933655f2.
There were no benchmark performance regressions. š
The [full Conbench report](https://github.com/apache/arrow/runs/90255004049) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50670: [Release][Dev]Fix only shellcheck SC2086 errors in the dev directory [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50671:
URL: https://github.com/apache/arrow/pull/50671#issuecomment-5099268487
:warning: GitHub issue #50670 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org