You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Ole Ersoy (JIRA)" <ji...@apache.org> on 2010/06/08 16:51:11 UTC
[jira] Created: (MATH-374) [Enhancement] Request for public
exception message strings on AbstractIntegerDistribution
[Enhancement] Request for public exception message strings on AbstractIntegerDistribution
-----------------------------------------------------------------------------------------
Key: MATH-374
URL: https://issues.apache.org/jira/browse/MATH-374
Project: Commons Math
Issue Type: Improvement
Affects Versions: 2.1
Reporter: Ole Ersoy
Priority: Minor
Fix For: 2.2
The Strings
/** Message for endpoints in wrong order. */
private static final String WRONG_ORDER_ENDPOINTS_MESSAGE =
"lower endpoint ({0}) must be less than or equal to upper endpoint ({1})";
/** Message for out of range point. */
private static final String OUT_OF_RANGE_POINT =
"{0} out of [{1}, {2}] range";
are private. It would be great if these were public, such that sub classes that override methods could maintain consistent exception messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-374) [Enhancement] Request for public
exception message strings on AbstractIntegerDistribution
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876695#action_12876695 ]
Gilles commented on MATH-374:
-----------------------------
Given the pending issue [MATH-361|https://issues.apache.org/jira/browse/MATH-361], I think that it would be a bad idea. [One of the goals being that the message strings are stored in a text file.]
Making them public (or protected) would cement them as part of the interface.
> [Enhancement] Request for public exception message strings on AbstractIntegerDistribution
> -----------------------------------------------------------------------------------------
>
> Key: MATH-374
> URL: https://issues.apache.org/jira/browse/MATH-374
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Ole Ersoy
> Priority: Minor
> Fix For: 2.2
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The Strings
> /** Message for endpoints in wrong order. */
> private static final String WRONG_ORDER_ENDPOINTS_MESSAGE =
> "lower endpoint ({0}) must be less than or equal to upper endpoint ({1})";
> /** Message for out of range point. */
> private static final String OUT_OF_RANGE_POINT =
> "{0} out of [{1}, {2}] range";
> are private. It would be great if these were public, such that sub classes that override methods could maintain consistent exception messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-374) [Enhancement] Request for public
exception message strings on AbstractIntegerDistribution
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877824#action_12877824 ]
Gilles commented on MATH-374:
-----------------------------
I've updated [issue 361|https://issues.apache.org/jira/browse/MATH-361].
You are most welcome to download the code and provide feedback.
> [Enhancement] Request for public exception message strings on AbstractIntegerDistribution
> -----------------------------------------------------------------------------------------
>
> Key: MATH-374
> URL: https://issues.apache.org/jira/browse/MATH-374
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Ole Ersoy
> Priority: Minor
> Fix For: 2.2
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The Strings
> /** Message for endpoints in wrong order. */
> private static final String WRONG_ORDER_ENDPOINTS_MESSAGE =
> "lower endpoint ({0}) must be less than or equal to upper endpoint ({1})";
> /** Message for out of range point. */
> private static final String OUT_OF_RANGE_POINT =
> "{0} out of [{1}, {2}] range";
> are private. It would be great if these were public, such that sub classes that override methods could maintain consistent exception messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-374) [Enhancement] Request for public
exception message strings on AbstractIntegerDistribution
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877094#action_12877094 ]
Ole Ersoy commented on MATH-374:
--------------------------------
OK - Once I understand what needs to be done, I'll take a chunk of the library and start making modifications. If you think there's anything else I can help with, just email me.
> [Enhancement] Request for public exception message strings on AbstractIntegerDistribution
> -----------------------------------------------------------------------------------------
>
> Key: MATH-374
> URL: https://issues.apache.org/jira/browse/MATH-374
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Ole Ersoy
> Priority: Minor
> Fix For: 2.2
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The Strings
> /** Message for endpoints in wrong order. */
> private static final String WRONG_ORDER_ENDPOINTS_MESSAGE =
> "lower endpoint ({0}) must be less than or equal to upper endpoint ({1})";
> /** Message for out of range point. */
> private static final String OUT_OF_RANGE_POINT =
> "{0} out of [{1}, {2}] range";
> are private. It would be great if these were public, such that sub classes that override methods could maintain consistent exception messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MATH-374) [Enhancement] Request for public
exception message strings on AbstractIntegerDistribution
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877033#action_12877033 ]
Gilles commented on MATH-374:
-----------------------------
Right now, I still have to provide a minimal working set of source files laying out the proposed changes.
If the idea is accepted, there will be a lot of modifications, and your help will come in handy; thank you for the offer.
> [Enhancement] Request for public exception message strings on AbstractIntegerDistribution
> -----------------------------------------------------------------------------------------
>
> Key: MATH-374
> URL: https://issues.apache.org/jira/browse/MATH-374
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Ole Ersoy
> Priority: Minor
> Fix For: 2.2
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The Strings
> /** Message for endpoints in wrong order. */
> private static final String WRONG_ORDER_ENDPOINTS_MESSAGE =
> "lower endpoint ({0}) must be less than or equal to upper endpoint ({1})";
> /** Message for out of range point. */
> private static final String OUT_OF_RANGE_POINT =
> "{0} out of [{1}, {2}] range";
> are private. It would be great if these were public, such that sub classes that override methods could maintain consistent exception messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (MATH-374) [Enhancement] Request for public
exception message strings on AbstractIntegerDistribution
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Ersoy closed MATH-374.
--------------------------
Resolution: Fixed
OK - I just closed the issue, since it looks like the "Framework" approach is under ways. Are there pieces in place that enables the same end goal ATM? Also - I'll be glad to help out with any refactoring or documentation development if anyone wants to point me in the right direction.
> [Enhancement] Request for public exception message strings on AbstractIntegerDistribution
> -----------------------------------------------------------------------------------------
>
> Key: MATH-374
> URL: https://issues.apache.org/jira/browse/MATH-374
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Ole Ersoy
> Priority: Minor
> Fix For: 2.2
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> The Strings
> /** Message for endpoints in wrong order. */
> private static final String WRONG_ORDER_ENDPOINTS_MESSAGE =
> "lower endpoint ({0}) must be less than or equal to upper endpoint ({1})";
> /** Message for out of range point. */
> private static final String OUT_OF_RANGE_POINT =
> "{0} out of [{1}, {2}] range";
> are private. It would be great if these were public, such that sub classes that override methods could maintain consistent exception messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.