Raw patch for harmony-mips

[Charles Hardin <ck...@gmail.com>]

All,

This is guaranteed to be nothing more then the work in progress in our
internal trees.

It can be used to see what we have done so far, and we will get the
rest out when we complete the work.

Thanks,
Charles

Re: Raw patch for harmony-mips

[Xiao-Feng Li <xi...@gmail.com>]

Thanks for the huge efforts!

Btw, what is OS for this patch?

Thanks,
xiaofeng

On Mon, Nov 16, 2009 at 11:55 AM, Charles Hardin <ck...@gmail.com> wrote:
> All,
>
> This is guaranteed to be nothing more then the work in progress in our
> internal trees.
>
> It can be used to see what we have done so far, and we will get the
> rest out when we complete the work.
>
> Thanks,
> Charles
>



-- 
http://people.apache.org/~xli

Re: Raw patch for harmony-mips

[Tianwei <ti...@gmail.com>]

Hi, Charles,
  I apply your patch, and build it on X86 linux machines, I met the
following compile time error:

[compile-cc] gcc -fpic -ftls-model=initial-exec -fno-exceptions -fPIC -O2 -g
-c -DAPR_DECLARE_EXPORT -DBUILDING_VM -DREFS_USE_RUNTIME_SWITCH -DNDEBUG
-D_EM64T_ -DHYX86_64 -DPOINTER64 -DLINUX -DPLATFORM_POSIX -D__SMP__
-D_REENTRANT -DLINUX_TLS_OPT
-I/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/include
-I/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/port/include
-I/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/port/src/thread/include
-I/home/tianwei/apache/harmony/trunk-mips/working_vm/build/linux_x86_64_gcc_release/deploy/include
-I/home/tianwei/apache/harmony/trunk-mips/working_classlib/deploy/include
/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/port/src/disasm/linux/disasm.c

[compile-cc]
/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/port/src/disasm/linux/disasm.c:31:24:
error: dec_simple.h: No such file or directory

[compile-cc]
/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/port/src/disasm/linux/disasm.c:
In function ‘port_disasm_set_info’:


[compile-cc]
/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/port/src/disasm/linux/disasm.c:276:
error: ‘ADDR_SIZE’ undeclared (first use in this function)

[compile-cc]
/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/port/src/disasm/linux/disasm.c:276:
error: (Each undeclared identifier is reported only once

[compile-cc]
/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/port/src/disasm/linux/disasm.c:276:
error: for each function it appears in.)

[compile-cc]
/home/tianwei/apache/harmony/trunk-mips/working_vm/vm/port/src/disasm/linux/disasm.c:285:
error: ‘BYTES_SIZE’ undeclared (first use in this function)


I check this problem, it's caused by the following diff:
--- ../../import/apache-harmony/working_vm/vm/port/src/disasm/linux/disasm.c
   2009-09-20 21:36:01.000000000 -0700
+++ harmony/working_vm/vm/port/src/disasm/linux/disasm.c        2009-11-15
19:37:02.000000000 -0800
@@ -29,6 +29,7 @@
 #include <apr_portable.h>

 #include "port_disasm.h"
+#include <dec_simple.h>

however, and two versions of dec_simple.h is added by this patch
 working_vm/vm/port/src/encoder/mips/dec_simple.h
 working_vm/vm/port/src/encoder/ia32_em64t/dec_simple.h

It seems that these files break the building on X86.

Tianwei
On Mon, Nov 16, 2009 at 11:55 AM, Charles Hardin <ck...@gmail.com> wrote:

> All,
>
> This is guaranteed to be nothing more then the work in progress in our
> internal trees.
>
> It can be used to see what we have done so far, and we will get the
> rest out when we complete the work.
>
> Thanks,
> Charles
>



-- 
Sheng, Tianwei
Inst. of High Performance Computing
Dept. of Computer Sci. & Tech.
Tsinghua Univ.

Re: Raw patch for harmony-mips

[Mark Hindess <ma...@googlemail.com>]

In message <61...@mail.gmail.com>,
Charles Hardin writes:
> 
> All,
> 
> This is guaranteed to be nothing more then the work in progress in our
> internal trees.
> 
> It can be used to see what we have done so far, and we will get the
> rest out when we complete the work.

Charles,

Could you attach this to a JIRA (and make sure you grant ASF permission
to use it)?  Could you also send any relevant documentation to the
private@harmony.apache.org to fulfil the contribution requirements
described at:

  http://harmony.apache.org/contribution_policy.html

If you need any help feel free to ask here or on the private@ list if
you prefer.

Regards,
 Mark.

Re: Raw patch for harmony-mips

[Mark Hindess <ma...@googlemail.com>]

In message <61...@mail.gmail.com>,
Charles Hardin writes:
>
> All,
> 
> This is guaranteed to be nothing more then the work in progress in our
> internal trees.
> 
> It can be used to see what we have done so far, and we will get the
> rest out when we complete the work.

I'm avoiding looking at your patch until it's been contributed with a
license grant.  However, I ran diffstat on it and noticed that it added
working_classlib/modules/portlib/src/main/native/thread/unix/mips32
with thrhelp.c and thrspinlock.c.  I don't know if you've implemented
these yet but if you build with -Dhy.no.thr=true then the threading
implementation from the drlvm port will be used and you wont need these
files.

Regards,
 Mark.