You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 14:36:55 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #25309: Add `op_classpath` in log

ashb commented on code in PR #25309:
URL: https://github.com/apache/airflow/pull/25309#discussion_r930046477


##########
airflow/jobs/scheduler_job.py:
##########
@@ -636,8 +636,24 @@ def _process_executor_events(self, session: Session) -> int:
                 "run_start_date=%s, run_end_date=%s, "
                 "run_duration=%s, state=%s, executor_state=%s, try_number=%s, max_tries=%s, job_id=%s, "
                 "pool=%s, queue=%s, priority_weight=%d, operator=%s, queued_dttm=%s, "
-                "queued_by_job_id=%s, pid=%s"
+                "queued_by_job_id=%s, pid=%s, op_classpath=%s"
             )
+
+            # Adding op_class path for the task instance log in order to track where the
+            # operator/sensor originated from
+            # Get task from the Serialized DAG
+            try:
+                dag = self.dagbag.get_dag(ti.dag_id)

Review Comment:
   This is, comparatively a _very_ expensive operation so I am wary of adding this feature like this without knowing how much it would impact performance in many large dags+high scheduling throughput cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org