You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/15 01:29:43 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8049: fix: onSave datasource raises React error

codecov-io commented on issue #8049:  fix: onSave datasource raises React error
URL: https://github.com/apache/incubator-superset/pull/8049#issuecomment-521480198
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=h1) Report
   > Merging [#8049](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ed8bb1b694e95df661bb99ff877097d749a0c9e0?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8049/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8049      +/-   ##
   ==========================================
   + Coverage   65.56%   65.56%   +<.01%     
   ==========================================
     Files         469      469              
     Lines       22480    22482       +2     
     Branches     2442     2444       +2     
   ==========================================
   + Hits        14739    14741       +2     
     Misses       7621     7621              
     Partials      120      120
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8049/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvTWV0cmljc0NvbnRyb2wuanN4) | `80.13% <100%> (+0.26%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=footer). Last update [ed8bb1b...055eaa9](https://codecov.io/gh/apache/incubator-superset/pull/8049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org