Re: [PATCH] Re: [Patch] Re: [PATCH] code file names linkified in general.html of the Hacking Guide

[Ben Reser <be...@reser.org>]

Not sure how I managed to leave the list off.  If that happens again
feel free to add the list back on.

Looks like Stefan has committed an earlier version of your patch.
I'll go ahead and fix up the changes from this patch to apply over
what he committed.

On Mon, Jan 7, 2013 at 12:53 PM, Gabriela Gibson
<ga...@gmail.com> wrote:
> On 07/01/13 01:15, Ben Reser wrote:
>>
>> On Sun, Jan 6, 2013 at 1:38 PM, Gabriela Gibson
>> <ga...@gmail.com> wrote:
>>>
>>> A new patch is attached.
>>
>>
>> Getting closer.
>>
>>>   (code-to-read): Create links for all file names to point to HTML
>>>    pretty-print versions.
>>
>>
>> I'd say you're linking to the docs, the pretty print version is linked
>> off the page you're linking to.  If there weren't other things I'd
>> have just changed this and committed it.
>>
> Hi Ben,
>
> Many thanks, your patience is very much valued.
>
> I don't like to chatter too much on the dev list to keep the bandwidth low,
> but I have a blog now that OPW asked me to start, and so I thought I share
> my patch woes with the other interns here:
>
> http://gabriela-gibson.blogspot.co.uk/2013/01/how-to-mess-up-patch-part-i.html
>
> Please keep being picky, otherwise, I won't ever learn :)
>
> regards
>
> Gabriela
> Ps.: you mailed me directly, I was not sure what to do in that case, as this
> actually should be on the mailing list, but I added chatter that I normally
> would not in this case.  Should I repost the 'business version' of this on
> the dev list?
>
>
>

Re: [PATCH] Re: [Patch] Re: [PATCH] code file names linkified in general.html of the Hacking Guide

[Ben Reser <be...@reser.org>]

On Tue, Jan 8, 2013 at 8:36 AM, Ben Reser <be...@reser.org> wrote:
> Not sure how I managed to leave the list off.  If that happens again
> feel free to add the list back on.
>
> Looks like Stefan has committed an earlier version of your patch.
> I'll go ahead and fix up the changes from this patch to apply over
> what he committed.

Done in r1430384.  Outside of rebasing the patch the only thing I did
was remove a duplicate trailing slash on the packages link.

Thanks for the contribution.