You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/10/19 20:34:12 UTC

[GitHub] [cordova-osx] raphinesse commented on pull request #115: refactor!: drop q

raphinesse commented on pull request #115:
URL: https://github.com/apache/cordova-osx/pull/115#issuecomment-947083959


   Thanks for the review @erisu!
   
   Since this PR might introduce slight changes in observed behavior (e.g. error handling in the binaries) and change the types of promises returned from public methods, this is probably major, right?
   
   If so, should we merge it now anyway?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org