You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/22 02:16:52 UTC

[GitHub] [flink] JingsongLi commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

JingsongLi commented on issue #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink
URL: https://github.com/apache/flink/pull/8435#issuecomment-494625782
 
 
   > I try to start reviewing from runtime package, and noticed that the old internal types haven't yet deleted, do you want to delete them in this PR or as a follow up issue?
   
   I prefer delete InternalTypes in follow up PR, If we delete `InternalType`, we need to have a conversion of `LogicalType` and `TypeInformation`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services