You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2022/07/26 16:29:29 UTC

[activemq-artemis] branch new-logging updated: some more integration test updates

This is an automated email from the ASF dual-hosted git repository.

robbie pushed a commit to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git


The following commit(s) were added to refs/heads/new-logging by this push:
     new e214c3c6c0 some more integration test updates
e214c3c6c0 is described below

commit e214c3c6c0d35a0e6b38743128aae8f2633a0180
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Tue Jul 26 17:28:39 2022 +0100

    some more integration test updates
---
 .../tests/integration/mqtt5/BasicSslTests.java     |  3 --
 .../mqtt5/CertificateAuthenticationSslTests.java   |  3 --
 .../artemis/tests/integration/mqtt5/MQTT5Test.java |  5 +-
 .../tests/integration/mqtt5/MQTT5TestSupport.java  |  7 +--
 .../openwire/CompactingOpenWireTest.java           |  5 +-
 .../integration/openwire/TempQueueWithDotTest.java |  3 --
 .../paging/IndividualAckPagingTest.java            |  2 -
 .../paging/MessagesExpiredPagingTest.java          |  5 +-
 .../tests/integration/paging/PageAckScanTest.java  |  3 --
 .../tests/integration/paging/PagingTest.java       | 58 +++++++++++-----------
 10 files changed, 42 insertions(+), 52 deletions(-)

diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/BasicSslTests.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/BasicSslTests.java
index 7ecc33a71c..6c459076e7 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/BasicSslTests.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/BasicSslTests.java
@@ -21,14 +21,11 @@ import java.util.Arrays;
 import java.util.Collection;
 
 import org.eclipse.paho.mqttv5.client.MqttClient;
-import org.jboss.logging.Logger;
 import org.junit.Test;
 import org.junit.runners.Parameterized;
 
 public class BasicSslTests extends MQTT5TestSupport {
 
-   private static final Logger log = Logger.getLogger(BasicSslTests.class);
-
    public BasicSslTests(String protocol) {
       super(protocol);
    }
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/CertificateAuthenticationSslTests.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/CertificateAuthenticationSslTests.java
index 1b46e07db0..ad3344000f 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/CertificateAuthenticationSslTests.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/CertificateAuthenticationSslTests.java
@@ -24,7 +24,6 @@ import java.util.Collection;
 import org.apache.activemq.artemis.core.server.ActiveMQServer;
 import org.apache.activemq.artemis.spi.core.security.ActiveMQJAASSecurityManager;
 import org.eclipse.paho.mqttv5.client.MqttClient;
-import org.jboss.logging.Logger;
 import org.junit.Test;
 import org.junit.runners.Parameterized;
 
@@ -41,8 +40,6 @@ public class CertificateAuthenticationSslTests extends MQTT5TestSupport {
       }
    }
 
-   private static final Logger log = Logger.getLogger(CertificateAuthenticationSslTests.class);
-
    public CertificateAuthenticationSslTests(String protocol) {
       super(protocol);
    }
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5Test.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5Test.java
index c2af69ede9..3f4f6add1f 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5Test.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5Test.java
@@ -40,16 +40,17 @@ import org.eclipse.paho.mqttv5.client.MqttConnectionOptionsBuilder;
 import org.eclipse.paho.mqttv5.common.MqttMessage;
 import org.eclipse.paho.mqttv5.common.packet.MqttProperties;
 import org.eclipse.paho.mqttv5.common.packet.UserProperty;
-import org.jboss.logging.Logger;
 import org.junit.Assume;
 import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /*
  * General tests for things not covered directly in the specification.
  */
 public class MQTT5Test extends MQTT5TestSupport {
 
-   private static final Logger log = Logger.getLogger(MQTT5Test.class);
+   private static final Logger log = LoggerFactory.getLogger(MQTT5Test.class);
 
    public MQTT5Test(String protocol) {
       super(protocol);
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5TestSupport.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5TestSupport.java
index f4fe3370f5..bc3cb6a3b2 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5TestSupport.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTT5TestSupport.java
@@ -67,13 +67,14 @@ import org.eclipse.paho.mqttv5.client.MqttDisconnectResponse;
 import org.eclipse.paho.mqttv5.client.persist.MemoryPersistence;
 import org.eclipse.paho.mqttv5.common.MqttException;
 import org.eclipse.paho.mqttv5.common.packet.MqttProperties;
-import org.jboss.logging.Logger;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.rules.TestName;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import static java.util.Collections.singletonList;
 import static org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManagerFactory.MQTT_PROTOCOL_NAME;
@@ -109,7 +110,7 @@ public class MQTT5TestSupport extends ActiveMQTestBase {
       return new MqttAsyncClient(protocol + "://localhost:" + (isUseSsl() ? getSslPort() : getPort()), clientId, new MemoryPersistence());
    }
 
-   private static final Logger log = Logger.getLogger(MQTT5TestSupport.class);
+   private static final Logger log = LoggerFactory.getLogger(MQTT5TestSupport.class);
    protected static final long DEFAULT_TIMEOUT = 300000;
    protected ActiveMQServer server;
 
@@ -166,7 +167,7 @@ public class MQTT5TestSupport extends ActiveMQTestBase {
       startBroker();
       createJMSConnection();
       //TODO: shouldnt really be doing this as it never resets the level
-      //org.jboss.logmanager.Logger.getLogger(MQTTUtil.class.getName()).setLevel(org.jboss.logmanager.Level.TRACE);
+      //TODO: org.jboss.logmanager.Logger.getLogger(MQTTUtil.class.getName()).setLevel(org.jboss.logmanager.Level.TRACE);
    }
 
    @Override
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/CompactingOpenWireTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/CompactingOpenWireTest.java
index c8a5b28cd7..dbc7d91b0b 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/CompactingOpenWireTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/CompactingOpenWireTest.java
@@ -37,14 +37,15 @@ import org.apache.activemq.artemis.core.config.Configuration;
 import org.apache.activemq.artemis.core.persistence.impl.journal.JournalRecordIds;
 import org.apache.activemq.artemis.core.server.JournalType;
 import org.apache.activemq.artemis.logs.AssertionLoggerHandler;
-import org.jboss.logging.Logger;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class CompactingOpenWireTest extends BasicOpenWireTest {
 
-   private static final Logger logger = Logger.getLogger(CompactingOpenWireTest.class);
+   private static final Logger logger = LoggerFactory.getLogger(CompactingOpenWireTest.class);
 
    @Override
    @Before
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/TempQueueWithDotTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/TempQueueWithDotTest.java
index ebfd3b28e1..52416a20ee 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/TempQueueWithDotTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/TempQueueWithDotTest.java
@@ -27,7 +27,6 @@ import javax.jms.Session;
 import org.apache.activemq.artemis.core.config.Configuration;
 import org.apache.activemq.artemis.tests.util.CFUtil;
 import org.apache.activemq.artemis.utils.Wait;
-import org.jboss.logging.Logger;
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -35,8 +34,6 @@ import org.junit.Test;
  * my box name was in the format of xxx-xxx.xxx when it failed. */
 public class TempQueueWithDotTest extends BasicOpenWireTest {
 
-   private static final Logger log = Logger.getLogger(TempQueueWithDotTest.class);
-
    @Override
    protected Configuration createDefaultConfig(final int serverID, final boolean netty) throws Exception {
       Configuration configuration = super.createDefaultConfig(serverID, netty);
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/IndividualAckPagingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/IndividualAckPagingTest.java
index cd8bd20efa..745f2f06a7 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/IndividualAckPagingTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/IndividualAckPagingTest.java
@@ -35,7 +35,6 @@ import org.apache.activemq.artemis.core.settings.impl.AddressFullMessagePolicy;
 import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
 import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
 import org.apache.activemq.artemis.tests.util.CFUtil;
-import org.jboss.logging.Logger;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -44,7 +43,6 @@ import org.junit.runners.Parameterized;
 
 @RunWith(Parameterized.class)
 public class IndividualAckPagingTest extends ActiveMQTestBase {
-   private static final Logger logger = Logger.getLogger(IndividualAckPagingTest.class);
 
    // Even though the focus of the test is paging, I'm adding non paging here to verify the test semantics itself
    @Parameterized.Parameters(name = "paging={0}, restartServerBeforeConsume={1}")
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/MessagesExpiredPagingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/MessagesExpiredPagingTest.java
index f2c3723076..40d36d25a1 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/MessagesExpiredPagingTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/MessagesExpiredPagingTest.java
@@ -39,15 +39,16 @@ import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
 import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
 import org.apache.activemq.artemis.tests.util.CFUtil;
 import org.apache.activemq.artemis.tests.util.Wait;
-import org.jboss.logging.Logger;
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class MessagesExpiredPagingTest extends ActiveMQTestBase {
 
-   private static final Logger logger = Logger.getLogger(MessagesExpiredPagingTest.class);
+   private static final Logger logger = LoggerFactory.getLogger(MessagesExpiredPagingTest.class);
 
    private static final String ADDRESS = "MessagesExpiredPagingTest";
 
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageAckScanTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageAckScanTest.java
index 1e085513d0..7276c4adaa 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageAckScanTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageAckScanTest.java
@@ -40,15 +40,12 @@ import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
 import org.apache.activemq.artemis.tests.util.CFUtil;
 import org.apache.activemq.artemis.utils.ReusableLatch;
 import org.apache.activemq.artemis.utils.Wait;
-import org.jboss.logging.Logger;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 
 public class PageAckScanTest extends ActiveMQTestBase {
 
-   private static final Logger logger = Logger.getLogger(PageAckScanTest.class);
-
    private static final String ADDRESS = "MessagesExpiredPagingTest";
 
    ActiveMQServer server;
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingTest.java
index 1214df64f1..d6551a8b4e 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PagingTest.java
@@ -117,7 +117,6 @@ import org.apache.activemq.artemis.tests.util.RandomUtil;
 import org.apache.activemq.artemis.tests.util.Wait;
 import org.apache.activemq.artemis.utils.RetryRule;
 import org.apache.activemq.artemis.utils.actors.ArtemisExecutor;
-import org.jboss.logging.Logger;
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Assume;
@@ -126,17 +125,17 @@ import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 @RunWith(Parameterized.class)
 public class PagingTest extends ActiveMQTestBase {
 
-   private static final Logger log = Logger.getLogger(PagingTest.class);
+   private static final Logger log = LoggerFactory.getLogger(PagingTest.class);
 
    @Rule
    public RetryRule retryMethod = new RetryRule(1);
 
-   private static final Logger logger = Logger.getLogger(PagingTest.class);
-
    protected ServerLocator locator;
    protected ActiveMQServer server;
    protected ClientSessionFactory sf;
@@ -894,8 +893,8 @@ public class PagingTest extends ActiveMQTestBase {
       sf = createSessionFactory(locator);
       session = sf.createSession(false, true, true);
 
-      logger.info("*******************************************************************************************************************************");
-      logger.info("Creating consumer");
+      log.info("*******************************************************************************************************************************");
+      log.info("Creating consumer");
 
       consumer = session.createConsumer(ADDRESS);
       session.start();
@@ -1066,7 +1065,7 @@ public class PagingTest extends ActiveMQTestBase {
       for (int i = 0; i < 10; i++) {
          ClientMessage msgRec = consumer.receive(1000);
          Assert.assertNotNull(msgRec);
-         logger.debugf("received i=%s page=%s",msgRec.getIntProperty("i"), msgRec.getIntProperty("page"));
+         log.debug("received i={} page={}", msgRec.getIntProperty("i"), msgRec.getIntProperty("page"));
          msgRec.acknowledge();
       }
       session.commit();
@@ -1122,7 +1121,7 @@ public class PagingTest extends ActiveMQTestBase {
             ClientMessage msgRec = browser.receive(1000);
             Assert.assertNotNull(msgRec);
 
-            logger.debugf("received i=%s page=%s", msgRec.getIntProperty("i"), msgRec.getIntProperty("page"));
+            log.debug("received i={} page={}", msgRec.getIntProperty("i"), msgRec.getIntProperty("page"));
 
             int pageProperty = msgRec.getIntProperty("page");
             Assert.assertTrue(pageProperty != 5 && pageProperty != 3);
@@ -1210,7 +1209,7 @@ public class PagingTest extends ActiveMQTestBase {
          for (int i = 0; i < numberOfMessages; i++) {
             ClientMessage msgRec = consumer.receive(1000);
             Assert.assertNotNull(msgRec);
-            logger.debug("msgRec, i=" + msgRec.getIntProperty("i") + ", page=" + msgRec.getIntProperty("page"));
+            log.debug("msgRec, i={}, page={}", msgRec.getIntProperty("i"), msgRec.getIntProperty("page"));
             msgRec.acknowledge();
          }
          session.commit();
@@ -2736,7 +2735,7 @@ public class PagingTest extends ActiveMQTestBase {
       sessionConsumer.start();
       ClientConsumer consumer = sessionConsumer.createConsumer(PagingTest.ADDRESS);
       for (int msgCount = 0; msgCount < numberOfMessages; msgCount++) {
-         log.debug("Received " + msgCount);
+         log.debug("Received {}", msgCount);
          msgReceived++;
          ClientMessage msg = consumer.receive(5000);
          if (msg == null) {
@@ -2818,7 +2817,7 @@ public class PagingTest extends ActiveMQTestBase {
       sessionConsumer.start();
       consumer = sessionConsumer.createConsumer(PagingTest.ADDRESS);
       for (int msgCount = 0; msgCount < numberOfMessages; msgCount++) {
-         log.debug("Received " + msgCount);
+         log.debug("Received {}", msgCount);
          msgReceived++;
          ClientMessage msg = consumer.receive(5000);
          if (msg == null) {
@@ -2944,7 +2943,7 @@ public class PagingTest extends ActiveMQTestBase {
       // a dumb user, or anything that will remove the data
       deleteDirectory(new File(getPageDir()));
 
-      logger.trace("Server restart");
+      log.trace("Server restart");
 
       server.start();
 
@@ -3394,7 +3393,7 @@ public class PagingTest extends ActiveMQTestBase {
 
             for (int i = 0; i < numberOfMessages; i++) {
                if (i % 500 == 0) {
-                  log.debug("Sent " + i + " messages");
+                  log.debug("Sent {} messages", i);
                   session.commit();
                }
                message = session.createMessage(true);
@@ -3640,8 +3639,8 @@ public class PagingTest extends ActiveMQTestBase {
                   try {
                      assertBodiesEqual(body, message2.getBodyBuffer());
                   } catch (AssertionError e) {
-                     PagingTest.log.debug("Expected buffer:" + ActiveMQTestBase.dumpBytesHex(body, 40));
-                     PagingTest.log.debug("Arriving buffer:" + ActiveMQTestBase.dumpBytesHex(message2.getBodyBuffer().toByteBuffer().array(), 40));
+                     log.debug("Expected buffer: {}", ActiveMQTestBase.dumpBytesHex(body, 40));
+                     log.debug("Arriving buffer: {}", ActiveMQTestBase.dumpBytesHex(message2.getBodyBuffer().toByteBuffer().array(), 40));
                      throw e;
                   }
                }
@@ -4276,7 +4275,7 @@ public class PagingTest extends ActiveMQTestBase {
          ClientMessage msg = consumer.receive(5000);
          assertNotNull(msg);
          if (i != msg.getIntProperty("count").intValue()) {
-            log.debug("Received " + i + " with property = " + msg.getIntProperty("count"));
+            log.debug("Received {} with property = {}", i,  msg.getIntProperty("count"));
             log.debug("###### different");
          }
          // assertEquals(i, msg.getIntProperty("count").intValue());
@@ -4383,8 +4382,8 @@ public class PagingTest extends ActiveMQTestBase {
          try {
             assertBodiesEqual(body, message2.getBodyBuffer());
          } catch (AssertionError e) {
-            PagingTest.log.debug("Expected buffer:" + ActiveMQTestBase.dumpBytesHex(body, 40));
-            PagingTest.log.debug("Arriving buffer:" + ActiveMQTestBase.dumpBytesHex(message2.getBodyBuffer().toByteBuffer().array(), 40));
+            log.debug("Expected buffer:" + ActiveMQTestBase.dumpBytesHex(body, 40));
+            log.debug("Arriving buffer:" + ActiveMQTestBase.dumpBytesHex(message2.getBodyBuffer().toByteBuffer().array(), 40));
             throw e;
          }
       }
@@ -4631,7 +4630,7 @@ public class PagingTest extends ActiveMQTestBase {
       server.stop();
       mainCleanup.set(false);
 
-      logger.trace("Server restart");
+      log.trace("Server restart");
 
       server.start();
 
@@ -5018,7 +5017,7 @@ public class PagingTest extends ActiveMQTestBase {
             count++;
 
             if (count % 1000 == 0) {
-               log.debug("received " + count);
+               log.debug("received {}", count);
             }
 
             try {
@@ -5958,7 +5957,7 @@ public class PagingTest extends ActiveMQTestBase {
          ClientProducer producer = session.createProducer(PagingTest.ADDRESS);
 
          for (int i = 0; i < 100; i++) {
-            log.debug("send message #" + i);
+            log.debug("send message #{}", i);
             ClientMessage message = session.createMessage(true);
 
             message.putStringProperty("id", "str" + i);
@@ -5997,7 +5996,7 @@ public class PagingTest extends ActiveMQTestBase {
          }
 
          for (int i = 2; i < 100; i++) {
-            log.debug("Received message " + i);
+            log.debug("Received message {}", i);
             ClientMessage message = cons.receive(5000);
             assertNotNull("Message " + i + " wasn't received", message);
             message.acknowledge();
@@ -6017,7 +6016,7 @@ public class PagingTest extends ActiveMQTestBase {
                   fail("Couldn't finish large message receiving");
                }
             } catch (Throwable e) {
-               log.debug("output bytes = " + bytesOutput);
+               log.debug("output bytes = {}", bytesOutput);
                log.debug(threadDump("dump"));
                fail("Couldn't finish large message receiving for id=" + message.getStringProperty("id") + " with messageID=" + message.getMessageID());
             }
@@ -6055,7 +6054,7 @@ public class PagingTest extends ActiveMQTestBase {
          cons = session.createConsumer(ADDRESS);
 
          for (int i = 2; i < 100; i++) {
-            log.debug("Received message " + i);
+            log.debug("Received message {}", i);
             ClientMessage message = cons.receive(5000);
             assertNotNull(message);
 
@@ -6164,7 +6163,7 @@ public class PagingTest extends ActiveMQTestBase {
 
          for (int i = 0; i < 500; i++) {
             if (i % 100 == 0)
-               log.debug("send message #" + i);
+               log.debug("send message #{}", i);
             message = session.createMessage(true);
 
             message.putStringProperty("id", "str" + i);
@@ -6218,7 +6217,7 @@ public class PagingTest extends ActiveMQTestBase {
          ClientConsumer cons = session.createConsumer("DLA");
 
          for (int i = 0; i < 500; i++) {
-            log.debug("Received message " + i);
+            log.debug("Received message {}",  i);
             message = cons.receive(10000);
             assertNotNull(message);
             message.acknowledge();
@@ -6251,14 +6250,15 @@ public class PagingTest extends ActiveMQTestBase {
       }
    }
 
-   @Test
    /**
     * When running this test from an IDE add this to the test command line so that the AssertionLoggerHandler works properly:
     *
-    *   -Djava.util.logging.manager=org.jboss.logmanager.LogManager  -Dlogging.configuration=file:<path_to_source>/tests/config/logging.properties
+    *   -Dlog4j2.configurationFile=file:<path_to_source>/tests/config/log4j2-tests-config.properties
     *
     *   Note: Idea should get these from the pom and you shouldn't need to do this.
-    */ public void testFailMessagesNonDurable() throws Exception {
+    */
+   @Test
+   public void testFailMessagesNonDurable() throws Exception {
       AssertionLoggerHandler.startCapture();
 
       try {