You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2019/06/26 17:24:09 UTC

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #249: Emit SDE when a type calculator attempts to use an undefined type.

stevedlawrence commented on a change in pull request #249: Emit SDE when a type calculator attempts to use an undefined type.
URL: https://github.com/apache/incubator-daffodil/pull/249#discussion_r297778696
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dsom/CompiledExpression1.scala
 ##########
 @@ -200,14 +205,23 @@ class DPathCompileInfo(
   val namespaces: scala.xml.NamespaceBinding,
   val path: String,
   override val schemaFileLocation: SchemaFileLocation,
-  val tunable: DaffodilTunables)
+  val tunable: DaffodilTunables,
+  @TransientParam val typeCalcMapArg: TypeCalcMap)
 
 Review comment:
   Does this variable need to be passed by-name? I forget why we had to do that, but all other TransientParams are by-name args.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services