You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "makinyemi (via GitHub)" <gi...@apache.org> on 2023/11/06 17:43:58 UTC
[PR] [YUNIKORN-2125] Remove literals from handlers_test.go [yunikorn-core]
makinyemi opened a new pull request, #699:
URL: https://github.com/apache/yunikorn-core/pull/699
### What is this PR for?
Some functions error message use string literals while others use constant variables available in the webservice pacakge. I replaced the hard coded messages with the corresponding constants.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2125
### How should this be tested?
n/a
### Screenshots (if appropriate)
n/a
### Questions:
n/a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2125] Remove literals from handlers_test.go [yunikorn-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #699:
URL: https://github.com/apache/yunikorn-core/pull/699#issuecomment-1795743527
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/699?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#699](https://app.codecov.io/gh/apache/yunikorn-core/pull/699?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7ea6456) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/ca733441da3b90c6c69388c83b2239dc8b20a5f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ca73344) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #699 +/- ##
=======================================
Coverage 77.63% 77.63%
=======================================
Files 80 80
Lines 13271 13271
=======================================
Hits 10303 10303
Misses 2648 2648
Partials 320 320
```
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2125] Remove literals from handlers_test.go [yunikorn-core]
Posted by "manirajv06 (via GitHub)" <gi...@apache.org>.
manirajv06 closed pull request #699: [YUNIKORN-2125] Remove literals from handlers_test.go
URL: https://github.com/apache/yunikorn-core/pull/699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org