[GitHub] spark pull request #18826: [SPARK-14712][ML] LogisticRegressionModel.toStrin...

[holdenk <gi...@git.apache.org>]

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18826#discussion_r197496908
  
    --- Diff: python/pyspark/ml/classification.py ---
    @@ -562,6 +564,11 @@ def evaluate(self, dataset):
             java_blr_summary = self._call_java("evaluate", dataset)
             return BinaryLogisticRegressionSummary(java_blr_summary)
     
    +    def __repr__(self):
    --- End diff --
    
    So my question here is why we aren't calling the Java/Scala toString method directly as we do in the mllib one and in many of the other models in `regression.py` for the ml one?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org