You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Claus Ibsen <cl...@gmail.com> on 2022/02/15 14:34:45 UTC
camel-package-maven-plugin
Hi
It seems it now does some output logging that is maybe not really
helpful or should be improved
[INFO] --- camel-package-maven-plugin:3.16.0-SNAPSHOT:generate
(generate) @ camel-aws-secrets-manager ---
[INFO] No previous run data found, generating files.
[INFO] Building index...
[INFO] Generated code 1 in: 7
[INFO] Generated code 1 in: 5
[INFO] Generated components containing 1 Camel component: aws-secrets-manager
[INFO] Validation complete
These lines
[INFO] Generated code 1 in: 7
[INFO] Generated code 1 in: 5
Because Camel is a big project then the less maven output noise the
better, so there is not endless maven output to wade through when
looking into something
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: camel-package-maven-plugin
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
That is great - that is about 1 min less time.
Also we can reach out to 3rd party maven plugin maintainers to help
reduce their logging noise. I did this for some of them like the
formatter plugin that is now 1 line.
On Tue, Feb 15, 2022 at 8:04 PM Otavio Rodolfo Piske
<an...@gmail.com> wrote:
>
> BTW, we should probably review the outputs we display on these plugins.
>
> Your comment gave me an idea to look at some of the other debug statements
> we have in that code. I have prepared a small PR with a few cleanups on
> them and I'm going to send after #6951 is merged.
>
> If my understanding of the Maven Daemon report is correct, this one I am
> going to send + the other cleanups, remove about 1 minute of plugin
> execution time (~35 seconds for the bundle plugin and ~30 seconds for the
> package plugin). Not enough to make our build agile, but does help a bit it
> seems.
>
> On Tue, Feb 15, 2022 at 7:07 PM Otavio Rodolfo Piske <an...@gmail.com>
> wrote:
>
> > Hi,
> >
> > This should do the trick: https://github.com/apache/camel/pull/6951. It
> > was a bogus debug message I left when cleaning up these plugins.
> >
> > Kind regards
> >
> > On Tue, Feb 15, 2022 at 6:55 PM Otavio Rodolfo Piske <an...@gmail.com>
> > wrote:
> >
> >> Hi
> >>
> >> I'll take a look at that one. I don't remember deliberately changing it,
> >> but it could be caused by one of the recent changes.
> >>
> >> On Tue, Feb 15, 2022 at 3:35 PM Claus Ibsen <cl...@gmail.com>
> >> wrote:
> >>
> >>> Hi
> >>>
> >>> It seems it now does some output logging that is maybe not really
> >>> helpful or should be improved
> >>>
> >>> [INFO] --- camel-package-maven-plugin:3.16.0-SNAPSHOT:generate
> >>> (generate) @ camel-aws-secrets-manager ---
> >>> [INFO] No previous run data found, generating files.
> >>> [INFO] Building index...
> >>> [INFO] Generated code 1 in: 7
> >>> [INFO] Generated code 1 in: 5
> >>> [INFO] Generated components containing 1 Camel component:
> >>> aws-secrets-manager
> >>> [INFO] Validation complete
> >>>
> >>>
> >>> These lines
> >>>
> >>> [INFO] Generated code 1 in: 7
> >>> [INFO] Generated code 1 in: 5
> >>>
> >>>
> >>> Because Camel is a big project then the less maven output noise the
> >>> better, so there is not endless maven output to wade through when
> >>> looking into something
> >>>
> >>>
> >>> --
> >>> Claus Ibsen
> >>> -----------------
> >>> http://davsclaus.com @davsclaus
> >>> Camel in Action 2: https://www.manning.com/ibsen2
> >>>
> >>
> >>
> >> --
> >> Otavio R. Piske
> >> http://orpiske.net
> >>
> >
> >
> > --
> > Otavio R. Piske
> > http://orpiske.net
> >
>
>
> --
> Otavio R. Piske
> http://orpiske.net
--
Claus Ibsen
-----------------
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2
Re: camel-package-maven-plugin
Posted by Otavio Rodolfo Piske <an...@gmail.com>.
BTW, we should probably review the outputs we display on these plugins.
Your comment gave me an idea to look at some of the other debug statements
we have in that code. I have prepared a small PR with a few cleanups on
them and I'm going to send after #6951 is merged.
If my understanding of the Maven Daemon report is correct, this one I am
going to send + the other cleanups, remove about 1 minute of plugin
execution time (~35 seconds for the bundle plugin and ~30 seconds for the
package plugin). Not enough to make our build agile, but does help a bit it
seems.
On Tue, Feb 15, 2022 at 7:07 PM Otavio Rodolfo Piske <an...@gmail.com>
wrote:
> Hi,
>
> This should do the trick: https://github.com/apache/camel/pull/6951. It
> was a bogus debug message I left when cleaning up these plugins.
>
> Kind regards
>
> On Tue, Feb 15, 2022 at 6:55 PM Otavio Rodolfo Piske <an...@gmail.com>
> wrote:
>
>> Hi
>>
>> I'll take a look at that one. I don't remember deliberately changing it,
>> but it could be caused by one of the recent changes.
>>
>> On Tue, Feb 15, 2022 at 3:35 PM Claus Ibsen <cl...@gmail.com>
>> wrote:
>>
>>> Hi
>>>
>>> It seems it now does some output logging that is maybe not really
>>> helpful or should be improved
>>>
>>> [INFO] --- camel-package-maven-plugin:3.16.0-SNAPSHOT:generate
>>> (generate) @ camel-aws-secrets-manager ---
>>> [INFO] No previous run data found, generating files.
>>> [INFO] Building index...
>>> [INFO] Generated code 1 in: 7
>>> [INFO] Generated code 1 in: 5
>>> [INFO] Generated components containing 1 Camel component:
>>> aws-secrets-manager
>>> [INFO] Validation complete
>>>
>>>
>>> These lines
>>>
>>> [INFO] Generated code 1 in: 7
>>> [INFO] Generated code 1 in: 5
>>>
>>>
>>> Because Camel is a big project then the less maven output noise the
>>> better, so there is not endless maven output to wade through when
>>> looking into something
>>>
>>>
>>> --
>>> Claus Ibsen
>>> -----------------
>>> http://davsclaus.com @davsclaus
>>> Camel in Action 2: https://www.manning.com/ibsen2
>>>
>>
>>
>> --
>> Otavio R. Piske
>> http://orpiske.net
>>
>
>
> --
> Otavio R. Piske
> http://orpiske.net
>
--
Otavio R. Piske
http://orpiske.net
Re: camel-package-maven-plugin
Posted by Otavio Rodolfo Piske <an...@gmail.com>.
Hi,
This should do the trick: https://github.com/apache/camel/pull/6951. It was
a bogus debug message I left when cleaning up these plugins.
Kind regards
On Tue, Feb 15, 2022 at 6:55 PM Otavio Rodolfo Piske <an...@gmail.com>
wrote:
> Hi
>
> I'll take a look at that one. I don't remember deliberately changing it,
> but it could be caused by one of the recent changes.
>
> On Tue, Feb 15, 2022 at 3:35 PM Claus Ibsen <cl...@gmail.com> wrote:
>
>> Hi
>>
>> It seems it now does some output logging that is maybe not really
>> helpful or should be improved
>>
>> [INFO] --- camel-package-maven-plugin:3.16.0-SNAPSHOT:generate
>> (generate) @ camel-aws-secrets-manager ---
>> [INFO] No previous run data found, generating files.
>> [INFO] Building index...
>> [INFO] Generated code 1 in: 7
>> [INFO] Generated code 1 in: 5
>> [INFO] Generated components containing 1 Camel component:
>> aws-secrets-manager
>> [INFO] Validation complete
>>
>>
>> These lines
>>
>> [INFO] Generated code 1 in: 7
>> [INFO] Generated code 1 in: 5
>>
>>
>> Because Camel is a big project then the less maven output noise the
>> better, so there is not endless maven output to wade through when
>> looking into something
>>
>>
>> --
>> Claus Ibsen
>> -----------------
>> http://davsclaus.com @davsclaus
>> Camel in Action 2: https://www.manning.com/ibsen2
>>
>
>
> --
> Otavio R. Piske
> http://orpiske.net
>
--
Otavio R. Piske
http://orpiske.net
Re: camel-package-maven-plugin
Posted by Otavio Rodolfo Piske <an...@gmail.com>.
Hi
I'll take a look at that one. I don't remember deliberately changing it,
but it could be caused by one of the recent changes.
On Tue, Feb 15, 2022 at 3:35 PM Claus Ibsen <cl...@gmail.com> wrote:
> Hi
>
> It seems it now does some output logging that is maybe not really
> helpful or should be improved
>
> [INFO] --- camel-package-maven-plugin:3.16.0-SNAPSHOT:generate
> (generate) @ camel-aws-secrets-manager ---
> [INFO] No previous run data found, generating files.
> [INFO] Building index...
> [INFO] Generated code 1 in: 7
> [INFO] Generated code 1 in: 5
> [INFO] Generated components containing 1 Camel component:
> aws-secrets-manager
> [INFO] Validation complete
>
>
> These lines
>
> [INFO] Generated code 1 in: 7
> [INFO] Generated code 1 in: 5
>
>
> Because Camel is a big project then the less maven output noise the
> better, so there is not endless maven output to wade through when
> looking into something
>
>
> --
> Claus Ibsen
> -----------------
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>
--
Otavio R. Piske
http://orpiske.net