[GitHub] orc pull request #253: ORC-346: [C++] Add one second when writing negative T...

[rip-nsk <gi...@git.apache.org>]

GitHub user rip-nsk opened a pull request:

    https://github.com/apache/orc/pull/253

    ORC-346: [C++] Add one second when writing negative Timestamp's with non zero nanos …

    …to match the reader code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rip-nsk/orc ORC-346

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #253
    
----
commit 0507d1f970c613fd7b12ee814fb9e040bfa30d24
Author: rip-nsk <ri...@...>
Date:   2018-04-19T19:22:09Z

    Add one second when writing negative Timestamp's with non zero nanos to match the reader code.

----


---

[GitHub] orc issue #253: ORC-346: [C++] Add one second when writing negative Timestam...

[omalley <gi...@git.apache.org>]

Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/253
  
    *Sigh* This is caused by the fact that Java defined Timestamp badly and then Hive copied those semantics into the ColumnVector.
    
    We really need to fix these semantics in ORCv2.
    
    I'll also comment that it would probably be nicer to our users if we weren't modifying the data in the columnVector they passed into us, but clearly we are already doing that.


---

[GitHub] orc issue #253: ORC-346: [C++] Add one second when writing negative Timestam...

[rip-nsk <gi...@git.apache.org>]

Github user rip-nsk commented on the issue:

    https://github.com/apache/orc/pull/253
  
    I'm not sure that it is correct fix, IMO, TimestampColumnReader should not do this:
            if (secsBuffer[i] < 0 && nanoBuffer[i] != 0) {
              secsBuffer[i] -= 1;
            }
    but it seems necessary to match the java reader.


---

[GitHub] orc pull request #253: ORC-346: [C++] Add one second when writing negative T...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/orc/pull/253


---