[jira] [Commented] (TRINIDAD-2490) skin additions are not loaded for simple, minimal and casablanca skins

["Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051787#comment-14051787 ] 

Jeanne Waldman commented on TRINIDAD-2490:
------------------------------------------

Sending content: C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\provider\SkinProviderRegistry.java  
Sending content: C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\provider\BaseSkinProvider.java  
Sending content: C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\SkinUtils.java  
Sending content: C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\config\GlobalConfiguratorImpl.java  
Sending content: C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\SkinImpl.java  
Sending content: C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\provider\TrinidadSkinProvider.java  
Sending content: C:\Trinidad\Trunk3\trinidad-api\src\main\java\org\apache\myfaces\trinidad\skin\SkinAddition.java  
Sending content: C:\Trinidad\Trunk3\trinidad-impl\src\main\java\org\apache\myfaces\trinidadinternal\skin\provider\ExternalSkinProvider.java  
Completed: At revision: 1607709  


> skin additions are not loaded for simple, minimal and casablanca skins
> ----------------------------------------------------------------------
>
>                 Key: TRINIDAD-2490
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2490
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 2.1.0-core
>            Reporter: Anand V Nath
>             Fix For: 2.1.1-core
>
>         Attachments: jira-2490.patch
>
>
> Skin additions present in trinidad-skins.xml are not loaded if the skin used
> is one of the Trinidad provided skins, such as "simple", "casablanca" or
> "minimal". Applications may add skin additions to these using
> trinidad-skins.xml and they should get loaded.
> For example: An application added a skin addition to simple.desktop using its trinidad-skins.xml and used "simple" skin family in its trinidad-config.xml. In this case, the skin addition that application added does not get picked up.
> This happens only for the default skins provided by trinidad out of the box.
> This bug appears after SkinProvider SPI and SkinFactory deprecation. Earlier SkinFactory used to eager load and process all skins at start-up. With SkinProvider we defer the skin load until the time user requests it. Default trinidad skins are handled by TriniadBaseSkinProvider and those defined in trinidad-skins.xml are handled by TrindiadSkinProvider. It is the responsibility of SkinProviderRegistry that coordinates between all SkinProviders to ensure that the skin additions added in TrindiadSkinProvider are applied to all skins. So I added this logic into SkinProviderRegistry. I also added more comments and javadoc for SkinProvider where I found it missing and did some rearrangements for coding standards compliance.



--
This message was sent by Atlassian JIRA
(v6.2#6252)