You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/06 21:43:47 UTC

[GitHub] [hudi] yihua commented on a diff in pull request #6349: [HUDI-4433] Hudi-CLI repair deduplicate not working with non-partitio…

yihua commented on code in PR #6349:
URL: https://github.com/apache/hudi/pull/6349#discussion_r964204175


##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/RepairsCommand.java:
##########
@@ -71,7 +71,7 @@ public class RepairsCommand implements CommandMarker {
       help = "De-duplicate a partition path contains duplicates & produce repaired files to replace with")
   public String deduplicate(
       @CliOption(key = {"duplicatedPartitionPath"}, help = "Partition Path containing the duplicates",
-          mandatory = true) final String duplicatedPartitionPath,
+          unspecifiedDefaultValue = "") final String duplicatedPartitionPath,

Review Comment:
   Thanks for the fix!  @brightwon could you add a simple test around this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org