[GitHub] [netbeans] blackleg commented on a change in pull request #1953: Test SimpleNotificationDisplayer implementation

[GitBox <gi...@apache.org>]

blackleg commented on a change in pull request #1953: Test SimpleNotificationDisplayer implementation
URL: https://github.com/apache/netbeans/pull/1953#discussion_r386107533
 
 

 ##########
 File path: platform/openide.awt/test/unit/src/org/openide/awt/NotificationDisplayerTest.java
 ##########
 @@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.openide.awt;
+
+import java.util.HashMap;
+import java.util.Map;
+import javax.swing.JComponent;
+import org.junit.Test;
+import org.netbeans.junit.NbTestCase;
+import org.openide.awt.NotificationDisplayer.Category;
+import org.openide.awt.NotificationDisplayer.Priority;
+
+/**
+ *
+ * @author Hector Espert
+ */
+public class NotificationDisplayerTest extends NbTestCase {
+    
+    private NotificationDisplayer notificationDisplayer;
+
+    public NotificationDisplayerTest(String name) {
+        super(name);
+    }
+    
+    @Override
+    public void setUp() {
+        notificationDisplayer = NotificationDisplayer.getDefault();
+        assertNotNull(notificationDisplayer);
+        assertEquals("SimpleNotificationDisplayer", notificationDisplayer.getClass().getSimpleName());
 
 Review comment:
   > Should we make assumptions about which NotificationDisplayer is the default? That's not specified by the API.
   
   It doesn't assume that `SimpleNotificationDisplayer` is the default NotificationDisplayer, only is for testing that if any other is not present, fallback implementation is loaded.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists