You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "AnandInguva (via GitHub)" <gi...@apache.org> on 2023/02/24 16:33:02 UTC

[GitHub] [beam] AnandInguva opened a new issue, #25625: [Task]: Update python code and doc strings that uses GCP dependencies

AnandInguva opened a new issue, #25625:
URL: https://github.com/apache/beam/issues/25625

   ### What needs to happen?
   
   Update python code and doc strings for the modules that uses GCP dependencies.  Seems like they use some old conventions and may require some refactoring to keep them up to date.
   
   For example, 
   1. https://github.com/apache/beam/tree/master/sdks/python/apache_beam/io/gcp/datastore/v1new
   2. https://github.com/apache/beam/tree/master/sdks/python/apache_beam/ml/gcp/
   
   ### Issue Priority
   
   Priority: 3 (nice-to-have improvement)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [ ] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on issue #25625: [Task]: Update python code and doc strings that uses GCP dependencies

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.

tvalentyn commented on issue #25625:
URL: https://github.com/apache/beam/issues/25625#issuecomment-1462543297

   Can you give an example of what exactly needs to be updated?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on issue #25625: [Task]: Update python code and doc strings that uses GCP dependencies

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.

AnandInguva commented on issue #25625:
URL: https://github.com/apache/beam/issues/25625#issuecomment-1464135410

   > Can you give an example of what exactly needs to be updated?
   
   https://github.com/apache/beam/blob/01cb7e9618db63c79cf1887d43d5b2ec50dc1736/sdks/python/apache_beam/ml/gcp/naturallanguageml.py#L43
   
   https://github.com/apache/beam/blob/01cb7e9618db63c79cf1887d43d5b2ec50dc1736/sdks/python/apache_beam/ml/gcp/naturallanguageml.py#L84
   
   We can update doc strings and add type annotations in the format `(pcoll: beam.pvalue.PCollection)` instead of `pcoll,  # type: beam.pvalue.PCollection`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org