You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhishekrb19 (via GitHub)" <gi...@apache.org> on 2023/07/10 22:54:59 UTC
[PR] Minor doc fixes. (druid)
abhishekrb19 opened a new pull request, #14565:
URL: https://github.com/apache/druid/pull/14565
This change includes a few doc fixes:
- The jvm monitor's name is case-sensitive, so keep it as `JvmMonitor`.
- Fixes missing paranthesis.
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Minor doc fixes. (druid)
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim merged PR #14565:
URL: https://github.com/apache/druid/pull/14565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Minor doc fixes. (druid)
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #14565:
URL: https://github.com/apache/druid/pull/14565#discussion_r1258989888
##########
docs/querying/lookups.md:
##########
@@ -79,7 +79,7 @@ In native queries, lookups can be queried with [dimension specs or extraction fu
Query Execution
---------------
-When executing an aggregation query involving lookup functions (like the SQL [`LOOKUP` function](sql-scalar.md#string-functions),
+When executing an aggregation query involving lookup functions, like the SQL [`LOOKUP` function](sql-scalar.md#string-functions),
Review Comment:
```suggestion
When executing an aggregation query involving lookup functions, like the SQL [`LOOKUP` function](sql-scalar.md#string-functions,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Minor doc fixes. (druid)
Posted by "vtlim (via GitHub)" <gi...@apache.org>.
vtlim commented on code in PR #14565:
URL: https://github.com/apache/druid/pull/14565#discussion_r1258989888
##########
docs/querying/lookups.md:
##########
@@ -79,7 +79,7 @@ In native queries, lookups can be queried with [dimension specs or extraction fu
Query Execution
---------------
-When executing an aggregation query involving lookup functions (like the SQL [`LOOKUP` function](sql-scalar.md#string-functions),
+When executing an aggregation query involving lookup functions, like the SQL [`LOOKUP` function](sql-scalar.md#string-functions),
Review Comment:
```suggestion
When executing an aggregation query involving lookup functions, like the SQL [`LOOKUP` function](sql-scalar.md#string-functions,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Minor doc fixes. (druid)
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #14565:
URL: https://github.com/apache/druid/pull/14565#discussion_r1259461565
##########
docs/operations/metrics.md:
##########
@@ -350,7 +350,7 @@ These metrics are for the Druid Coordinator and are reset each time the Coordina
### JVM
-These metrics are only available if the `JVMMonitor` module is included.
+These metrics are only available if the `JvmMonitor` module is included.
Review Comment:
Nit:
```suggestion
These metrics are only available if the `JvmMonitor` module is included in `druid.monitoring.monitors`.
```
You could even link to this https://druid.apache.org/docs/latest/configuration/index.html#enabling-metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org