You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 01:01:33 UTC
Review Request 70090: Addressed issues flagged by pylint-2.3.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70090/
-----------------------------------------------------------
Review request for mesos and Armand Grillet.
Repository: mesos
Description
-------
Addressed issues flagged by pylint-2.3.0.
Diffs
-----
src/python/cli_new/lib/cli/exceptions.py c78f4a97debdb89cc9972c89c5c1ea249836713b
src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd
support/common.py 845a687b6f92c66e1ae367701e96335f1c86b5de
support/pip-requirements.txt c8839fd2471826e8ca6bc023b3a0f4a38af9f899
support/verify-reviews.py 377792dd6f958ea8b138ca4d62fcd15b1c0bc9be
Diff: https://reviews.apache.org/r/70090/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 70090: Addressed issues flagged by pylint-2.3.1.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70090/#review213376
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On March 3, 2019, 12:39 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70090/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 12:39 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Bugs: MESOS-9629
> https://issues.apache.org/jira/browse/MESOS-9629
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Addressed issues flagged by pylint-2.3.1.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/exceptions.py c78f4a97debdb89cc9972c89c5c1ea249836713b
> src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd
> support/common.py 845a687b6f92c66e1ae367701e96335f1c86b5de
> support/verify-reviews.py 377792dd6f958ea8b138ca4d62fcd15b1c0bc9be
>
>
> Diff: https://reviews.apache.org/r/70090/diff/2/
>
>
> Testing
> -------
>
> * `make check`
> * `./support/mesos-style.py`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70090: Addressed issues flagged by pylint-2.3.1.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70090/
-----------------------------------------------------------
(Updated March 3, 2019, 12:39 p.m.)
Review request for mesos and Armand Grillet.
Changes
-------
Upgrade to 2.3.1 instead
Summary (updated)
-----------------
Addressed issues flagged by pylint-2.3.1.
Bugs: MESOS-9629
https://issues.apache.org/jira/browse/MESOS-9629
Repository: mesos
Description (updated)
-------
Addressed issues flagged by pylint-2.3.1.
Diffs (updated)
-----
src/python/cli_new/lib/cli/exceptions.py c78f4a97debdb89cc9972c89c5c1ea249836713b
src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd
support/common.py 845a687b6f92c66e1ae367701e96335f1c86b5de
support/verify-reviews.py 377792dd6f958ea8b138ca4d62fcd15b1c0bc9be
Diff: https://reviews.apache.org/r/70090/diff/2/
Changes: https://reviews.apache.org/r/70090/diff/1-2/
Testing (updated)
-------
* `make check`
* `./support/mesos-style.py`
Thanks,
Benjamin Bannier
Re: Review Request 70090: Addressed issues flagged by pylint-2.3.0.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70090/#review213363
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On March 3, 2019, 2:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70090/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 2:01 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Addressed issues flagged by pylint-2.3.0.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/exceptions.py c78f4a97debdb89cc9972c89c5c1ea249836713b
> src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd
> support/common.py 845a687b6f92c66e1ae367701e96335f1c86b5de
> support/pip-requirements.txt c8839fd2471826e8ca6bc023b3a0f4a38af9f899
> support/verify-reviews.py 377792dd6f958ea8b138ca4d62fcd15b1c0bc9be
>
>
> Diff: https://reviews.apache.org/r/70090/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>