You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/09 18:56:16 UTC

[GitHub] [arrow] westonpace opened a new pull request #10498: ARROW-13027: [C++] Fix ASAN stack traces in CI

westonpace opened a new pull request #10498:
URL: https://github.com/apache/arrow/pull/10498


   Before change:
   
   ```
   Direct leak of 65536 byte(s) in 1 object(s) allocated from:
       #0 0x522f09 in
       #1 0x7f28ae5826f4 in
       #2 0x7f28ae57fa5d in
       #3 0x7f28ae58cb0f in
       #4 0x7f28ae58bda0 in
   ```
   
   After change:
   ```
   Direct leak of 65536 byte(s) in 1 object(s) allocated from:
       #0 0x522f09 in posix_memalign (/build/cpp/debug/arrow-dataset-file-csv-test+0x522f09)
       #1 0x7f28ae5826f4 in arrow::(anonymous namespace)::SystemAllocator::AllocateAligned(long, unsigned char**) /arrow/cpp/src/arrow/memory_pool.cc:213:24
       #2 0x7f28ae57fa5d in arrow::BaseMemoryPoolImpl<arrow::(anonymous namespace)::SystemAllocator>::Allocate(long, unsigned char**) /arrow/cpp/src/arrow/memory_pool.cc:405:5
       #3 0x7f28ae58cb0f in arrow::PoolBuffer::Reserve(long) /arrow/cpp/src/arrow/memory_pool.cc:717:9
       #4 0x7f28ae58bda0 in arrow::PoolBuffer::Resize(long, bool) /arrow/cpp/src/arrow/memory_pool.cc:741:7
       ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #10498: ARROW-13027: [C++] Fix ASAN stack traces in CI

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #10498:
URL: https://github.com/apache/arrow/pull/10498


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #10498: ARROW-13027: [C++] Fix ASAN stack traces in CI

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10498:
URL: https://github.com/apache/arrow/pull/10498#issuecomment-861652093


   This will be a welcome improvement :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10498: ARROW-13027: [C++] Fix ASAN stack traces in CI

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10498:
URL: https://github.com/apache/arrow/pull/10498#issuecomment-858037852


   https://issues.apache.org/jira/browse/ARROW-13027


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on a change in pull request #10498: ARROW-13027: [C++] Fix ASAN stack traces in CI

Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #10498:
URL: https://github.com/apache/arrow/pull/10498#discussion_r648596421



##########
File path: docker-compose.yml
##########
@@ -372,6 +372,7 @@ services:
       ARROW_S3: "OFF"
       ARROW_USE_ASAN: "ON"
       ARROW_USE_UBSAN: "ON"
+      ASAN_SYMBOLIZER_PATH: /usr/lib/llvm-12/bin/llvm-symbolizer

Review comment:
       Should that be added to the Dockerfile instead? Presumably it depends on the Ubuntu version.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] westonpace commented on pull request #10498: ARROW-13027: [C++] Fix ASAN stack traces in CI

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #10498:
URL: https://github.com/apache/arrow/pull/10498#issuecomment-858021084


   Good catch.  The dockerfile also has a variable for llvm version so I don't have to hard code 12.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org