[jira] [Comment Edited] (FALCON-507) HiveCatalogService has hardcode the database name "default" to check whether the service is up.

["Sushanth Sowmyan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FALCON-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076919#comment-14076919 ] 

Sushanth Sowmyan edited comment on FALCON-507 at 7/28/14 9:32 PM:
------------------------------------------------------------------

I would agree, "show databases" is probably a better test. As long as you don't get an exception from that call, you're good.

Edit: And I believe that's what we used to have as part of hcat_ping from https://issues.apache.org/jira/browse/HCATALOG-389 


was (Author: sushanth):
I would agree, "show databases" is probably a better test. As long as you don't get an exception from that call, you're good.

> HiveCatalogService has hardcode the database name "default" to check whether the service is up. 
> ------------------------------------------------------------------------------------------------
>
>                 Key: FALCON-507
>                 URL: https://issues.apache.org/jira/browse/FALCON-507
>             Project: Falcon
>          Issue Type: Bug
>    Affects Versions: 0.5
>            Reporter: Venkatesh Seetharam
>              Labels: hive
>             Fix For: 0.6
>
>
> Don Bosco Durai reported in an email to me:
> While debugging the issue, it seems HiveCatalogService has hardcode the database name "default" to check whether the service is up. I think this check will fail if the customer has dropped the database "default" in production.
> {code}
> @Override
>     public boolean isAlive(final String catalogUrl,
>                            final String metaStorePrincipal) throws FalconException {
>         LOG.info("Checking if the service is alive for: " + catalogUrl);
>         try {
>             HCatClient client = getProxiedClient(catalogUrl, metaStorePrincipal);
>             HCatDatabase database = client.getDatabase("default");
>             return database != null;
>         } catch (HCatException e) {
>             throw new FalconException("Exception checking if the service is alive:" + e.getMessage(), e);
>         }
>     }
> {code}
> Thanks Bosco.



--
This message was sent by Atlassian JIRA
(v6.2#6252)