You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/16 09:30:00 UTC

[jira] [Commented] (MNG-7476) Display a warning when an aggregator mojo is locking other mojo executions

    [ https://issues.apache.org/jira/browse/MNG-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537421#comment-17537421 ] 

ASF GitHub Bot commented on MNG-7476:
-------------------------------------

gnodet commented on code in PR #736:
URL: https://github.com/apache/maven/pull/736#discussion_r873515895


##########
maven-core/src/main/java/org/apache/maven/internal/MessageHelper.java:
##########
@@ -0,0 +1,91 @@
+package org.apache.maven.internal;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class to format warning messages to the console
+ */
+public class MessageHelper
+{
+
+    private static final int DEFAULT_MAX_SIZE = 65;
+    private static final char BOX_CHAR = '*';
+
+    public static String separatorLine()
+    {
+        StringBuilder sb = new StringBuilder( DEFAULT_MAX_SIZE );
+        repeat( sb, '*', DEFAULT_MAX_SIZE );
+        return sb.toString();
+    }
+
+    public static List<String> formatWarning( String... lines )
+    {
+        int size = DEFAULT_MAX_SIZE;
+        int rem = size - 4;

Review Comment:
   I've added a comment, I don't think it warrants a constant as it can not be changed.





> Display a warning when an aggregator mojo is locking other mojo executions
> --------------------------------------------------------------------------
>
>                 Key: MNG-7476
>                 URL: https://issues.apache.org/jira/browse/MNG-7476
>             Project: Maven
>          Issue Type: Improvement
>    Affects Versions: 3.8.5
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 3.8.6, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)