You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by rnewson <gi...@git.apache.org> on 2015/08/10 20:10:36 UTC
[GitHub] couchdb-couch pull request: CSRF is not necessary for read operati...
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch/pull/84
CSRF is not necessary for read operations
COUCHDB-2762
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch 2762-no-csrf-for-reads
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit 553ab08b85c2c5775e998ccd6eed7b9148d57d4f
Author: Robert Newson <rn...@apache.org>
Date: 2015-08-10T18:09:29Z
CSRF is not necessary for read operations
COUCHDB-2762
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: CSRF is not necessary for read operati...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: CSRF is not necessary for read operati...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/84#issuecomment-129559067
@rnewson if you fit it in 80 line right margin - ok (: Personally, I found your initial version more readable - less syntax noise around the valuable data, but fine with both solutions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: CSRF is not necessary for read operati...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/84#issuecomment-129557387
+1
I see only problems with _update handler(where GET is disabled on query server side, not httpd => custom query server may create/modify documents on GET) and custom externals which could not respect REST and do modifications on GET, but here we can nothing much to do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: CSRF is not necessary for read operati...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/84#issuecomment-129558187
Any preference for a single clause version?
`validate(#httpd{method = Method}) when Method == 'GET'; Method == 'HEAD'; Method == 'OPTIONS' ->`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: CSRF is not necessary for read operati...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/84#issuecomment-129559606
I'll go with the original then. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---