You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/05 10:41:32 UTC
[GitHub] [tvm] masahi opened a new pull request #7413: [VM] Minor refactor for C++ memory alloc
masahi opened a new pull request #7413:
URL: https://github.com/apache/tvm/pull/7413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zhiics commented on a change in pull request #7413: [VM] Minor refactor for C++ memory alloc
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #7413:
URL: https://github.com/apache/tvm/pull/7413#discussion_r571317011
##########
File path: tests/python/frontend/pytorch/test_object_detection.py
##########
@@ -162,3 +162,8 @@ def compile_and_run_vm(mod, params, data_np, target):
# Results should be equivalent after rewriting
for res1, res2 in zip(tvm_res, tvm_res_after_rewrite):
tvm.testing.assert_allclose(res1.asnumpy(), res2.asnumpy())
+
Review comment:
remove this and `in_size` above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a change in pull request #7413: [VM] Minor refactor for C++ memory alloc
Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #7413:
URL: https://github.com/apache/tvm/pull/7413#discussion_r571317465
##########
File path: tests/python/frontend/pytorch/test_object_detection.py
##########
@@ -162,3 +162,8 @@ def compile_and_run_vm(mod, params, data_np, target):
# Results should be equivalent after rewriting
for res1, res2 in zip(tvm_res, tvm_res_after_rewrite):
tvm.testing.assert_allclose(res1.asnumpy(), res2.asnumpy())
+
Review comment:
oops will fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a change in pull request #7413: [VM] Minor refactor for C++ memory alloc
Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #7413:
URL: https://github.com/apache/tvm/pull/7413#discussion_r571318273
##########
File path: src/relay/op/tensor/tensor.h
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file tensor.h
+ * \brief Declarations for tensor operations.
+ */
+#ifndef TVM_RELAY_OP_TENSOR_TENSOR_H_
+#define TVM_RELAY_OP_TENSOR_TENSOR_H_
+
+#include "tvm/relay/expr.h"
+
+namespace tvm {
+namespace relay {
+
+Expr Prod(Expr data, Array<Integer> axis, bool keepdims, bool exclude);
Review comment:
Thanks, didn't notice reduce ops are also defined there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zhiics commented on a change in pull request #7413: [VM] Minor refactor for C++ memory alloc
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #7413:
URL: https://github.com/apache/tvm/pull/7413#discussion_r571315365
##########
File path: src/relay/op/tensor/tensor.h
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file tensor.h
+ * \brief Declarations for tensor operations.
+ */
+#ifndef TVM_RELAY_OP_TENSOR_TENSOR_H_
+#define TVM_RELAY_OP_TENSOR_TENSOR_H_
+
+#include "tvm/relay/expr.h"
+
+namespace tvm {
+namespace relay {
+
+Expr Prod(Expr data, Array<Integer> axis, bool keepdims, bool exclude);
Review comment:
BTW, we already have a bunch of op definitions in 'pattern_utils.h'. We can probably move this one there as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zhiics merged pull request #7413: [VM] Minor refactor for C++ memory alloc
Posted by GitBox <gi...@apache.org>.
zhiics merged pull request #7413:
URL: https://github.com/apache/tvm/pull/7413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a change in pull request #7413: [VM] Minor refactor for C++ memory alloc
Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #7413:
URL: https://github.com/apache/tvm/pull/7413#discussion_r571319484
##########
File path: src/relay/op/tensor/tensor.h
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file tensor.h
+ * \brief Declarations for tensor operations.
+ */
+#ifndef TVM_RELAY_OP_TENSOR_TENSOR_H_
+#define TVM_RELAY_OP_TENSOR_TENSOR_H_
+
+#include "tvm/relay/expr.h"
+
+namespace tvm {
+namespace relay {
+
+Expr Prod(Expr data, Array<Integer> axis, bool keepdims, bool exclude);
Review comment:
But I do find that it is a bit weird to declare those make-op in `patterns_utils.`. `tensor.h` would be more appropriate, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org