[GitHub] cxfeng1 closed pull request #1567: [WEEX-629][iOS] fix report firstScreenRenderTime failed

[GitBox <gi...@apache.org>]

cxfeng1 closed pull request #1567: [WEEX-629][iOS] fix report firstScreenRenderTime failed
URL: https://github.com/apache/incubator-weex/pull/1567
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m b/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
index e4866dda04..914835456d 100644
--- a/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
+++ b/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
@@ -67,6 +67,9 @@ + (void)performancePoint:(WXPerformanceTag)tag didEndWithInstance:(WXSDKInstance
     }
     
     dict[kEndKey] = @(CACurrentMediaTime() * 1000);
+    if (tag == WXPTFirstScreenRender) {
+        [instance.apmInstance onStage:KEY_PAGE_STAGES_FSRENDER];
+    }
 
 //    if (tag == WXPTAllRender) {
 //        [self performanceFinish:instance];
@@ -236,11 +239,6 @@ + (void)commitPerformanceWithDict:(NSMutableDictionary *)commitDict instance:(WX
         if (appMonitor && [appMonitor respondsToSelector:@selector(commitAppMonitorArgs:)]){
             [appMonitor commitAppMonitorArgs:commitDict];
         }
-        long oldFSRenderCostTime = [commitDict[FSRENDERTIME] longValue];
-        if (oldFSRenderCostTime > 0) {
-            long oldFSRenderTime = instance.performance.renderUnixTimeOrigin + oldFSRenderCostTime;
-            [instance.apmInstance onStageWithTime:KEY_PAGE_STAGES_FSRENDER time:oldFSRenderTime];
-        }
         
         [self printPerformance:commitDict];
         [WXTracingManager commitTracingSummaryInfo:commitDict withInstanceId:instance.instanceId];


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services