[GitHub] [sling-org-apache-sling-feature-analyser] rombert commented on a change in pull request #17: SLING-8873 - Validate the sourceId property at build time

[GitBox <gi...@apache.org>]

rombert commented on a change in pull request #17: SLING-8873 - Validate the sourceId property at build time
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/17#discussion_r354369543
 
 

 ##########
 File path: src/main/java/org/apache/sling/feature/analyser/task/impl/CheckApisJarsProperties.java
 ##########
 @@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.sling.feature.analyser.task.impl;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.sling.feature.Artifact;
+import org.apache.sling.feature.ArtifactId;
+import org.apache.sling.feature.analyser.task.AnalyserTask;
+import org.apache.sling.feature.analyser.task.AnalyserTaskContext;
+
+/**
+ * This analyser validates that the entries related to Apis Jar are valid.
+ * 
+ * Current checks:
+ * 
+ * <ol>
+ *  <li>The <tt>sourceId</tt> property is a CSV list of valid artifact ids.</li>
+ * </ol>
+ *
+ */
+public class CheckApisJarsProperties implements AnalyserTask {
+    
+    // TODO - also defined in ApisJarMojo
 
 Review comment:
   I was wondering whether there is a good place to define this so it's accessible from both the Maven plug-in and the analyser ( @bosschaert , @cziegeler )

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services