You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "rebel-shshin (via GitHub)" <gi...@apache.org> on 2023/07/07 07:20:50 UTC

[GitHub] [tvm] rebel-shshin opened a new pull request, #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

rebel-shshin opened a new pull request, #15259:
URL: https://github.com/apache/tvm/pull/15259

   Fix a couple of variable names for tflite frontend.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] rebel-shshin commented on pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "rebel-shshin (via GitHub)" <gi...@apache.org>.
rebel-shshin commented on PR #15259:
URL: https://github.com/apache/tvm/pull/15259#issuecomment-1628880751

   cc @leandron 
   Hi @leandron, I added two test cases as you requested. Please take a look :-) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "leandron (via GitHub)" <gi...@apache.org>.
leandron commented on PR #15259:
URL: https://github.com/apache/tvm/pull/15259#issuecomment-1630624179

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] rebel-shshin commented on pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "rebel-shshin (via GitHub)" <gi...@apache.org>.
rebel-shshin commented on PR #15259:
URL: https://github.com/apache/tvm/pull/15259#issuecomment-1630873471

   > > Hi @leandron, any idea why `gpu/pr-head` fails?
   > > I think my patch should not be affected the gpu test.
   > 
   > It's probably a transient - I triggered a new set of CI for this patch now.
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] rebel-shshin commented on pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "rebel-shshin (via GitHub)" <gi...@apache.org>.
rebel-shshin commented on PR #15259:
URL: https://github.com/apache/tvm/pull/15259#issuecomment-1624893122

   Please take a look :-). @leandron @masahi @xiaosibai @neildhickey 
   cheers~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "leandron (via GitHub)" <gi...@apache.org>.
leandron commented on PR #15259:
URL: https://github.com/apache/tvm/pull/15259#issuecomment-1630624623

   > Hi @leandron, any idea why `gpu/pr-head` fails?
   > I think my patch should not be affected the gpu test.
   
   Tips probably a transient - I triggered a new set of CI for this patch now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] rebel-shshin commented on pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "rebel-shshin (via GitHub)" <gi...@apache.org>.
rebel-shshin commented on PR #15259:
URL: https://github.com/apache/tvm/pull/15259#issuecomment-1630248428

   Hi @leandron, any idea why `gpu/pr-head` fail?
   I think my patch should not be affected the gpu test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron merged pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "leandron (via GitHub)" <gi...@apache.org>.
leandron merged PR #15259:
URL: https://github.com/apache/tvm/pull/15259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15259:
URL: https://github.com/apache/tvm/pull/15259#issuecomment-1624879476

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @leandron <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] rebel-shshin commented on pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "rebel-shshin (via GitHub)" <gi...@apache.org>.
rebel-shshin commented on PR #15259:
URL: https://github.com/apache/tvm/pull/15259#issuecomment-1628586897

   > Interesting that we don't see any test failing because of that. Any chance you could add a small test case to make sure it doesn't regress in future?
   > 
   > Thanks for the PR @rebel-shshin
   
   Yeap I will do that :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #15259: [FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func

Posted by "leandron (via GitHub)" <gi...@apache.org>.
leandron commented on PR #15259:
URL: https://github.com/apache/tvm/pull/15259#issuecomment-1631435592

   This is merged now, thanks all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org