You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2010/10/15 21:27:33 UTC
[jira] Created: (LUCENE-2710) "reproduce with" on test failure
isn't right if you manually overrided anything
"reproduce with" on test failure isn't right if you manually overrided anything
-------------------------------------------------------------------------------
Key: LUCENE-2710
URL: https://issues.apache.org/jira/browse/LUCENE-2710
Project: Lucene - Java
Issue Type: Bug
Reporter: Michael McCandless
If you run a test with eg -Dtests.codec=SimpleText...
If it fails, the "reproduce with" fails to include that manual override (-Dtests.codec=SimpleText), ie it only includes the seed / test class / test method. So it won't actually reproduce the fail, in general.
We just need to fix the "reproduce with" to add any manual overrides....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2710) "reproduce with" on test failure
isn't right if you manually overrided anything
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921655#action_12921655 ]
Michael McCandless commented on LUCENE-2710:
--------------------------------------------
Works great for me! +1 to commit.
> "reproduce with" on test failure isn't right if you manually overrided anything
> -------------------------------------------------------------------------------
>
> Key: LUCENE-2710
> URL: https://issues.apache.org/jira/browse/LUCENE-2710
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Michael McCandless
> Attachments: LUCENE-2710.patch
>
>
> If you run a test with eg -Dtests.codec=SimpleText...
> If it fails, the "reproduce with" fails to include that manual override (-Dtests.codec=SimpleText), ie it only includes the seed / test class / test method. So it won't actually reproduce the fail, in general.
> We just need to fix the "reproduce with" to add any manual overrides....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2710) "reproduce with" on test failure
isn't right if you manually overrided anything
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921657#action_12921657 ]
Uwe Schindler commented on LUCENE-2710:
---------------------------------------
+1
Only: If you use StringBuilder, maybe use it to create the complete string reported (upper part uses "+"). But thats only tests, so not important for perf, just a general style question.
> "reproduce with" on test failure isn't right if you manually overrided anything
> -------------------------------------------------------------------------------
>
> Key: LUCENE-2710
> URL: https://issues.apache.org/jira/browse/LUCENE-2710
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Michael McCandless
> Attachments: LUCENE-2710.patch
>
>
> If you run a test with eg -Dtests.codec=SimpleText...
> If it fails, the "reproduce with" fails to include that manual override (-Dtests.codec=SimpleText), ie it only includes the seed / test class / test method. So it won't actually reproduce the fail, in general.
> We just need to fix the "reproduce with" to add any manual overrides....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2710) "reproduce with" on test failure
isn't right if you manually overrided anything
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2710.
---------------------------------
Resolution: Fixed
Fix Version/s: 4.0
3.1
Assignee: Robert Muir
I changed the +'s to stringbuilder appends,
Committed revision 1023250, 1023256 (3x)
> "reproduce with" on test failure isn't right if you manually overrided anything
> -------------------------------------------------------------------------------
>
> Key: LUCENE-2710
> URL: https://issues.apache.org/jira/browse/LUCENE-2710
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Michael McCandless
> Assignee: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2710.patch
>
>
> If you run a test with eg -Dtests.codec=SimpleText...
> If it fails, the "reproduce with" fails to include that manual override (-Dtests.codec=SimpleText), ie it only includes the seed / test class / test method. So it won't actually reproduce the fail, in general.
> We just need to fix the "reproduce with" to add any manual overrides....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2710) "reproduce with" on test failure
isn't right if you manually overrided anything
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2710:
--------------------------------
Attachment: LUCENE-2710.patch
here's a patch
> "reproduce with" on test failure isn't right if you manually overrided anything
> -------------------------------------------------------------------------------
>
> Key: LUCENE-2710
> URL: https://issues.apache.org/jira/browse/LUCENE-2710
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Michael McCandless
> Attachments: LUCENE-2710.patch
>
>
> If you run a test with eg -Dtests.codec=SimpleText...
> If it fails, the "reproduce with" fails to include that manual override (-Dtests.codec=SimpleText), ie it only includes the seed / test class / test method. So it won't actually reproduce the fail, in general.
> We just need to fix the "reproduce with" to add any manual overrides....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org