You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Hasnaathussain (via GitHub)" <gi...@apache.org> on 2026/08/19 08:36:01 UTC
[PR] Fix CASE evaluation for custom column expressions [datafusion]
Hasnaathussain opened a new pull request, #24484:
URL: https://github.com/apache/datafusion/pull/24484
## Which issue does this PR close?
- Closes #21231.
## Rationale for this change
A custom column-like `PhysicalExpr` can read an input column without downcasting to DataFusion's concrete `Column` type. CASE's internal projection then misses that dependency and evaluates the expression against a zero-column batch, causing a runtime error.
## What changes are included in this PR?
CASE projection now falls back to the original input batch when it encounters an unknown leaf expression. Known columns, lambda variables, literals, and composite expressions keep the existing projection optimization.
The regression test uses a custom `PhysicalExpr` that wraps a column without exposing a concrete `Column` node.
## Are these changes tested?
Yes:
- `cargo fmt --all -- --check`
- `cargo clippy -p datafusion-physical-expr --all-targets --all-features -- -D warnings`
- `cargo test -p datafusion-physical-expr expressions::case::tests` (36 passed)
- `cargo test -p datafusion-physical-expr` (1,596 passed, 2 ignored; 13 doctests passed)
The extended workspace command also reached the existing TPC-H q15 unparser failure. Its multi-statement error reproduces unchanged at the base commit, outside this patch.
## Are there any user-facing changes?
Custom physical expressions can now be evaluated correctly inside searched CASE expressions. There is no public API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#issuecomment-5520450839
🚀
@Hasnaathussain
Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "Hasnaathussain (via GitHub)" <gi...@apache.org>.
Hasnaathussain commented on PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#issuecomment-5461480018
Addressed in 48b72e44c and rebased onto current `main` (0f5590264).
- Centralized the projection decision in `ProjectedCaseBody::projection_for` and documented the `supports_projection` invariant.
- Kept DataFusion `ScalarFunctionExpr` leaves projectable; unknown leaf expressions still use the full batch.
- Added regression coverage for searched CASE, base-expression CASE, and the single-WHEN expression path with a column-like custom `PhysicalExpr`, plus a nullary `random()` fast-path check.
- Updated the description to mark this as a conservative part of #21231; the broader dependency-reporting design remains separate work.
The branch is conflict-free after the rebase and the repository checks are running on the new head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#issuecomment-5503665469
<!-- semver-check-comment -->
Thank you for opening this pull request!
Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
<details>
<summary>Details</summary>
```
Cloning apache/main
Building datafusion-physical-expr v55.0.0 (current)
Built [ 39.123s] (current)
Parsing datafusion-physical-expr v55.0.0 (current)
Parsed [ 0.050s] (current)
Building datafusion-physical-expr v55.0.0 (baseline)
Built [ 31.195s] (baseline)
Parsing datafusion-physical-expr v55.0.0 (baseline)
Parsed [ 0.050s] (baseline)
Checking datafusion-physical-expr v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 0.341s] 223 checks: 220 pass, 3 fail, 0 warn, 31 skip
--- failure derive_trait_impl_removed: built-in derived trait no longer implemented ---
Description:
A public type has stopped deriving one or more traits. This can break downstream code that depends on those types implementing those traits.
ref: https://doc.rust-lang.org/reference/attributes/derive.html#derive
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/derive_trait_impl_removed.ron
Failed in:
type TryCastExpr no longer derives Clone, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/expressions/try_cast.rs:34
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_missing.ron
Failed in:
function datafusion_physical_expr::expressions::try_cast_with_target_field, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/try_cast.rs:298
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron
Failed in:
CastExpr::target_metadata, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/cast.rs:171
CastExpr::target_nullable, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/cast.rs:176
CastExpr::has_explicit_metadata, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/cast.rs:204
CastExpr::has_explicit_nullability, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/cast.rs:209
TryCastExpr::new_with_target_field, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/try_cast.rs:105
TryCastExpr::target_metadata, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/try_cast.rs:127
TryCastExpr::target_field, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/465c32999df67c977c2c553cdde2196f0ff0adac/datafusion/physical-expr/src/expressions/try_cast.rs:136
Summary semver requires new major version: 3 major and 0 minor checks failed
Finished [ 71.846s] datafusion-physical-expr
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew merged PR #24484:
URL: https://github.com/apache/datafusion/pull/24484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "kosiew (via GitHub)" <gi...@apache.org>.
kosiew commented on code in PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#discussion_r3872993929
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -141,6 +142,11 @@ impl CaseBody {
expr.downcast_ref::<LambdaVariable>()
{
used_column_indices.insert(lambda_variable.index());
+ } else if expr.downcast_ref::<Literal>().is_none()
Review Comment:
I think this check is a little broader than the specific hazard we are trying to protect against. It will also disable CASE projection for some in-tree leaf expressions that cannot actually read the input batch positionally.
For example, a nullary `ScalarFunctionExpr` such as `random()` has no children, is not a `Literal`, and is not const-folded because it is volatile. That means an expression like `CASE WHEN random() < 0.5 THEN a ELSE b END` would now lose the projection fast path on a wide batch.
Would it make sense to keep known-safe DataFusion leaves projection-enabled, and reserve this fallback for expressions whose dependencies we genuinely cannot determine? If we prefer the conservative behavior for now, I think it would be worth calling out the performance tradeoff in the PR description.
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -1878,6 +1935,38 @@ mod tests {
Ok(())
}
+ #[test]
+ fn case_without_expr_with_custom_column() -> Result<()> {
Review Comment:
Nice regression test. One thing I noticed is that this currently covers only the `NoExpression` evaluation path, while the PR adds the same projection guard to `case_when_with_expr` and `expr_or_expr` as well.
Could we add small tests for those two shapes too? A base-expression CASE using `CustomColumn`, plus a single-WHEN-with-ELSE case, would make sure all three guarded paths stay covered if this code is refactored later.
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -141,6 +142,11 @@ impl CaseBody {
expr.downcast_ref::<LambdaVariable>()
{
used_column_indices.insert(lambda_variable.index());
+ } else if expr.downcast_ref::<Literal>().is_none()
+ && expr.children().is_empty()
+ {
+ // Unknown leaves may read input columns without exposing a Column child.
Review Comment:
This looks like a reasonable conservative fix for the reported crash. One process point though: the discussion in #21231 was also considering a `PhysicalExpr` dependency-reporting extension point, or a dedicated opt-in/opt-out mechanism for projection.
This PR takes a narrower approach by treating unknown leaves as unsafe. I think that is fine as a targeted fix, but it would be helpful to say so explicitly in the PR description and use wording like `Part of #21231` rather than closing the issue entirely. The separate scope-aware traversal problem still remains.
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
Review Comment:
Small cleanup suggestion: the logic that filters the projection to valid batch indices, checks whether projection is supported, and decides whether projection is worthwhile is now repeated in three places.
A helper on `ProjectedCaseBody`, something like `projection_for(&self, batch) -> Option<Vec<usize>>`, could centralize that decision. That would also make it harder for a future CASE evaluation path to accidentally forget the `supports_projection` check.
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -251,6 +258,7 @@ impl CaseBody {
struct ProjectedCaseBody {
projection: Vec<usize>,
body: CaseBody,
+ supports_projection: bool,
Review Comment:
Could we document the invariant on `supports_projection` here? When this is `false`, the derived `projection` and rewritten `body` must not be used, and evaluation needs to fall back to the original CASE body on the full batch.
That relationship is important enough that a short field comment, plus a sentence in the `ProjectedCaseBody` docs, would make the representation much easier to reason about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "Hasnaathussain (via GitHub)" <gi...@apache.org>.
Hasnaathussain commented on code in PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#discussion_r3889640560
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -141,6 +142,11 @@ impl CaseBody {
expr.downcast_ref::<LambdaVariable>()
{
used_column_indices.insert(lambda_variable.index());
+ } else if expr.downcast_ref::<Literal>().is_none()
Review Comment:
Addressed in `48b72e44c`: known-safe `ScalarFunctionExpr` leaves remain projectable, while unknown leaves use the full-batch path. The regression suite also covers a nullary `random()` expression.
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -1878,6 +1935,38 @@ mod tests {
Ok(())
}
+ #[test]
+ fn case_without_expr_with_custom_column() -> Result<()> {
Review Comment:
Added coverage for the three guarded evaluation shapes: searched CASE, base-expression CASE, and the single-WHEN-with-ELSE path, each using a column-like custom expression.
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -251,6 +258,7 @@ impl CaseBody {
struct ProjectedCaseBody {
projection: Vec<usize>,
body: CaseBody,
+ supports_projection: bool,
Review Comment:
Documented the `supports_projection` invariant next to the representation and in the `ProjectedCaseBody` docs: when it is false, evaluation must use the original CASE body against the full batch.
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -141,6 +142,11 @@ impl CaseBody {
expr.downcast_ref::<LambdaVariable>()
{
used_column_indices.insert(lambda_variable.index());
+ } else if expr.downcast_ref::<Literal>().is_none()
+ && expr.children().is_empty()
+ {
+ // Unknown leaves may read input columns without exposing a Column child.
Review Comment:
The PR description now calls this `Part of #21231` and states the scope explicitly. The dependency-reporting extension discussed in the issue remains separate work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#issuecomment-5439574841
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/24484?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `62.68657%` with `25 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.24%. Comparing base ([`c429919`](https://app.codecov.io/gh/apache/datafusion/commit/c429919c7c8bd81e4e687531a609e2380ed60649?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d4a8b0f`](https://app.codecov.io/gh/apache/datafusion/commit/d4a8b0fbf269a765eb5d7b5b6c913b3fdd248552?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 111 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/24484?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [datafusion/physical-expr/src/expressions/case.rs](https://app.codecov.io/gh/apache/datafusion/pull/24484?src=pr&el=tree&filepath=datafusion%2Fphysical-expr%2Fsrc%2Fexpressions%2Fcase.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9leHByZXNzaW9ucy9jYXNlLnJz) | 62.68% | [22 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/24484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #24484 +/- ##
==========================================
- Coverage 81.24% 81.24% -0.01%
==========================================
Files 1113 1113
Lines 392744 392808 +64
Branches 392744 392808 +64
==========================================
+ Hits 319090 319122 +32
- Misses 54900 54924 +24
- Partials 18754 18762 +8
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/24484?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#issuecomment-5462512084
<!-- semver-check-comment -->
Thank you for opening this pull request!
Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).
<details>
<summary>Details</summary>
```
Cloning apache/main
Building datafusion-physical-expr v55.0.0 (current)
Built [ 30.183s] (current)
Parsing datafusion-physical-expr v55.0.0 (current)
Parsed [ 0.049s] (current)
Building datafusion-physical-expr v55.0.0 (baseline)
Built [ 29.319s] (baseline)
Parsing datafusion-physical-expr v55.0.0 (baseline)
Parsed [ 0.047s] (baseline)
Checking datafusion-physical-expr v55.0.0 -> v55.0.0 (no change; assume patch)
Checked [ 0.346s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron
Failed in:
RangePartitioning::is_compatible_with_expressions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/680bdecb06ddc3d5798fc0e22de76db4186fbb50/datafusion/physical-expr/src/partitioning.rs:287
RangePartitioning::adapt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/680bdecb06ddc3d5798fc0e22de76db4186fbb50/datafusion/physical-expr/src/partitioning.rs:308
Partitioning::adapt, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/680bdecb06ddc3d5798fc0e22de76db4186fbb50/datafusion/physical-expr/src/partitioning.rs:574
Summary semver requires new major version: 1 major and 0 minor checks failed
Finished [ 60.979s] datafusion-physical-expr
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "Hasnaathussain (via GitHub)" <gi...@apache.org>.
Hasnaathussain commented on PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#issuecomment-5468966432
The first post-rebase run caught two fixture typos and the clippy-required branch shape. I corrected the ELSE expectations to 40, reordered the imports, and collapsed the nested else-if in 6c1847f4f. Rust 1.97 validation in WSL passes rustfmt, strict physical-expr clippy, all three custom-column regressions, and the full physical-expr library suite (1,629 passed, 2 ignored). Fresh workflows are currently waiting for the repository approval gate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix CASE evaluation for custom column expressions [datafusion]
Posted by "Hasnaathussain (via GitHub)" <gi...@apache.org>.
Hasnaathussain commented on PR #24484:
URL: https://github.com/apache/datafusion/pull/24484#issuecomment-5469345301
I refreshed the branch onto current `main` (`74f4dd6fe`) after the semver report showed unrelated `RangePartitioning` API drift between the PR base and current main.
The functional diff is still limited to `datafusion/physical-expr/src/expressions/case.rs`; the three contributor commits remain DCO-signed. The clean-base validation passes: `cargo fmt --all -- --check`, the 39 CASE tests, and strict physical-expr clippy with `-D warnings`. The reviewer’s four live suggestions are addressed in the current source and the PR description, and I replied inline to each thread. The rebased head is `f48c0e990`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org