You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/14 16:10:23 UTC

[GitHub] [spark] mridulm commented on a change in pull request #29750: [SPARK-32878][CORE] Avoid scheduling TaskSetManager which has no pending tasks

mridulm commented on a change in pull request #29750:
URL: https://github.com/apache/spark/pull/29750#discussion_r488053599



##########
File path: core/src/main/scala/org/apache/spark/scheduler/Pool.scala
##########
@@ -107,7 +109,7 @@ private[spark] class Pool(
     for (schedulable <- sortedSchedulableQueue) {
       sortedTaskSetQueue ++= schedulable.getSortedTaskSetQueue
     }
-    sortedTaskSetQueue
+    sortedTaskSetQueue.filter(_.isSchedulable)

Review comment:
       minor nit: Move this check to `schedulable.getSortedTaskSetQueue` in the loop ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org