[GitHub] [drill] paul-rogers commented on a change in pull request #1683: DRILL-6952: Host compliant text reader on the row set framework

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #1683: DRILL-6952: Host compliant text reader on the row set framework
URL: https://github.com/apache/drill/pull/1683#discussion_r264072871
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/rowSet/impl/TestProjectedTuple.java
 ##########
 @@ -353,9 +352,10 @@ public void testSimpleAndArray() {
     assertEquals(ProjectionType.UNPROJECTED, projSet.projectionType("foo"));
   }
 
-  @Test
-  @Ignore("Drill syntax does not support map arrays")
-  public void testMapArray() {
+  //@Test
 
 Review comment:
   Will be fixed in another PR. It seems that the Drill parser does not allow a project list item of the form:
   
   SELECT m[10].a FROM ...
   
   However, the SchemaPath class does support this construct. This test is meant to handle this case since it is valid in the code, even if not supported in SQL syntax (I think.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services