[GitHub] [cloudstack] ravening commented on a change in pull request #5114: Display all volumes to root admin

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #5114:
URL: https://github.com/apache/cloudstack/pull/5114#discussion_r710890046



##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2006,9 +2007,9 @@
         sb.and("display", sb.entity().isDisplayVolume(), SearchCriteria.Op.EQ);
         sb.and("state", sb.entity().getState(), SearchCriteria.Op.EQ);
         sb.and("stateNEQ", sb.entity().getState(), SearchCriteria.Op.NEQ);
-        sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.NEQ);
+        sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.IN);

Review comment:
       @nvazquez I still need this change since I need to assign both 0 and 1 for root admin

##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -2006,9 +2007,9 @@
         sb.and("display", sb.entity().isDisplayVolume(), SearchCriteria.Op.EQ);
         sb.and("state", sb.entity().getState(), SearchCriteria.Op.EQ);
         sb.and("stateNEQ", sb.entity().getState(), SearchCriteria.Op.NEQ);
-        sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.NEQ);
+        sb.and("systemUse", sb.entity().isSystemUse(), SearchCriteria.Op.IN);
         // display UserVM volumes only
-        sb.and().op("type", sb.entity().getVmType(), SearchCriteria.Op.NIN);
+        sb.and().op("type", sb.entity().getVmType(), SearchCriteria.Op.IN);

Review comment:
       this can be avoided




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org