You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/26 14:42:40 UTC
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer opened a new pull request #9: Bug netbeansinfra 187
jmborer opened a new pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9
This PR fixes and improves several things:
1) it fixes the issue netbeansinfra 187
2) it fixes the way the extra clusters are injected into a NB Platform whose name is not "netbeans"
3) replaced the hardcoded "netbeans" directory name in target/nbm by "clusters" when generating those clusters
These fixes allow now to properly work and build plugins for Netbeans based application other than than the IDE such as the VisualVM for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
jmborer commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620091096
Do you know if there is a Jenkins build somewhere for this plugin on the Apache Infra?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620031664
Better later to avoid confusion.
Did you link your account https://gitbox.apache.org/setup/ ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620012695
you have mvn checkstyle:check to have help on what is wrong, line length and method size we negledtec.
I think we can go for a NetBeans default format that will ease our work later. but once we review the ongoing PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-619840431
Hi @jmborer , there are coding style issue that make modification hard to review. curly brackt at new line and space on parenthesis. This is 'maven style'
System.err.println(">>>>>>>>> " are for debug ? maybe use getLog().debug ( ) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer edited a comment on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
jmborer edited a comment on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620037172
> Better later to avoid confusion.
>
> Did you link your account https://gitbox.apache.org/setup/ ?
No. Sorry I am quite new to all this ecosystem. I tried to link the accounts and get:
"MFA Status:
User not a member of the ASF GitHub organisation. Please make sure you are a part of the ASF Organisation on GitHub and have 2FA enabled. Visit id.apache.org and set your GitHub ID to be invited to the org."
Strange because I am a PMC Netbeans member...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
jmborer commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620055292
well I am using 2FA for GitHub. I have not idea why it doesn't recognise it and I double checked that I configured the proper userid on id.apache.org. Still no luck:
<img width="1086" alt="image" src="https://user-images.githubusercontent.com/6607350/80389777-d60a3600-88ab-11ea-8adb-504510065420.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620049186
your github account need to be protected by 2 factors authentication. and then you can use it.
Once connected PMC rights (merging commit) will be available on your github.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
jmborer commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620017308
> you have mvn checkstyle:check to have help on what is wrong, line length and method size we negledtec.
>
> I think we can go for a NetBeans default format that will ease our work later. but once we review the ongoing PR.
I have run check style. Well actually there are a lot of warnings that don't come from my modification. Do you want me to use the opportunity to fix them all before commit the change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
jmborer commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-619997515
Here are the preferences.
[java-maven-coding-style.zip](https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/files/4540018/java-maven-coding-style.zip)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
jmborer commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-619934965
Hi Eric,
I forgot to remove some of my debugging traces. I will turn them into log.
Concerning the coding style, I was to prone to hit "reformat" in my netbeans.
I will reformat and fix the logs and then redo a PR.
By the way is there a Netbeans formatting profile for Maven code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] geertjanw commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620056252
Best to file an Apache INFRA issue under GITBOX component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
jmborer commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620037172
> Better later to avoid confusion.
>
> Did you link your account https://gitbox.apache.org/setup/ ?
No. Sorry I am quite new to all this ecosystem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
jmborer commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-619996792
I applied the coding styles recommended on: https://maven.apache.org/developers/conventions/code.html
by properly configuring my Netbeans preferences. I opened as well the Eclipse profile to determine some details to be the most compliant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jmborer commented on pull request #9: NETBEANSINFRA-187 Bug netbeansinfra 187
Posted by GitBox <gi...@apache.org>.
jmborer commented on pull request #9:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/9#issuecomment-620036087
There are still a few "line too long" or "method length too long" remaining. Nothing critical IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists