You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by xiaoyong03 <gi...@git.apache.org> on 2017/09/21 06:38:26 UTC

[GitHub] storm pull request #2336: STORM-2750���fix HBaseSecurityUtil double_checked ...

GitHub user xiaoyong03 opened a pull request:

    https://github.com/apache/storm/pull/2336

    STORM-2750：fix HBaseSecurityUtil double_checked locking

    update HBaseSecurityUtil singleton to fix double_checked locking
    See url link for details: http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xiaoyong03/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2336
    
----
commit 225f99af97e1baceba5563e9dc2e19b373c6cd5c
Author: xiaoyong03 <fu...@126.com>
Date:   2017-09-20T08:44:24Z

     fix HBaseSecurityUtil    double_checked,  
    
    update HBaseSecurityUtil singleton to fix double_checked,  http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html

commit 66cccdb4e825e347d60d04f89b0cef26ac0384c6
Author: xiaoyong03 <fu...@126.com>
Date:   2017-09-21T06:24:03Z

    Update HBaseSecurityUtil.java

commit 1a1d42f2b11c17cd78ae9d350642b7fca66be260
Author: xiaoyong03 <fu...@126.com>
Date:   2017-09-21T06:36:31Z

    STORM-2750：fix double_checked locking
    
    update HBaseSecurityUtil singleton to fix double_checked locking
    See url link for details: http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html

----


---

[GitHub] storm issue #2336: STORM-2750���fix double_checked locking

Posted by xiaoyong03 <gi...@git.apache.org>.
Github user xiaoyong03 commented on the issue:

    https://github.com/apache/storm/pull/2336
  
    @srdo  I have  created an issue for this at https://issues.apache.org/jira and then rename the PR and commit message to contain the issue number as your request.
    thanks for the review


---

[GitHub] storm issue #2336: STORM-2750���fix double_checked locking

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2336
  
    +1 Nice finding.


---

[GitHub] storm issue #2336: STORM-2750���fix double_checked locking

Posted by xiaoyong03 <gi...@git.apache.org>.
Github user xiaoyong03 commented on the issue:

    https://github.com/apache/storm/pull/2336
  
    thanks @srdo . I squashd my commits to one. 


---

[GitHub] storm issue #2336: STORM-2750���fix double_checked locking

Posted by xiaoyong03 <gi...@git.apache.org>.
Github user xiaoyong03 commented on the issue:

    https://github.com/apache/storm/pull/2336
  
    @revans2  this is found in our other projec, and I find there is the same bug in strom while reading source code with static analysis.


---

[GitHub] storm pull request #2336: STORM-2750���fix double_checked locking

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2336


---

[GitHub] storm issue #2336: STORM-2750���fix double_checked locking

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2336
  
    +1, thanks @xiaoyong03. Please squash to one commit and we'll merge after the 24 hour waiting period.


---

[GitHub] storm issue #2336: STORM-2750���fix double_checked locking

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2336
  
    Thanks @xiaoyong03, merged to master and 1.x-branch. Keep up the good work :)


---