[jira] [Created] (STORM-2747) Make the windowing classes use long instead of int for time parameters, and rename millisecond based time parameters so it's clear which unit they are.

["Stig Rohde Døssing (JIRA)" <ji...@apache.org>]

Stig Rohde Døssing created STORM-2747:
-----------------------------------------

             Summary: Make the windowing classes use long instead of int for time parameters, and rename millisecond based time parameters so it's clear which unit they are.
                 Key: STORM-2747
                 URL: https://issues.apache.org/jira/browse/STORM-2747
             Project: Apache Storm
          Issue Type: Improvement
    Affects Versions: 2.0.0, 1.1.1, 1.0.5
            Reporter: Stig Rohde Døssing
            Priority: Minor


Some parameters in the windowing classes are using int instead of long for describing time, which requires a bunch of casting to/from long in the code. Some variables are always in milliseconds but are named e.g. "value", which makes it easy to accidentally use the wrong timeunit. Such variables should be named e.g. "valueMs" to disambiguate the unit.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)