[GitHub] [kafka] stan-confluent opened a new pull request, #12924: try-finally around super call in http.py

[GitBox <gi...@apache.org>]

stan-confluent opened a new pull request, #12924:
URL: https://github.com/apache/kafka/pull/12924

   Adds a safety check in `HttpMetricsCollector` - if the `super()` call fails we still want to shut down httpd thread.
   
   The issue with `HttpMetricsCollector` is that it starts httpd thread on object creation, not inside `start()` method. However, it's been like that for many years, and I don't want to change the logic since it might introduce issues in other places - I don't have bandwidth to hunt them down, unfortunately.
   
   So instead I'm adding a try-finally block in `stop()` which will make sure that http metrics thread is shutdown regardless of whether  or not the super() call was successful.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] omkreddy merged pull request #12924: try-finally around super call in http.py

[GitBox <gi...@apache.org>]

omkreddy merged PR #12924:
URL: https://github.com/apache/kafka/pull/12924


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org