You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucy.apache.org by nw...@apache.org on 2016/09/07 15:48:58 UTC

[1/7] lucy-clownfish git commit: Fix Clownfish::Test::run_tests

Repository: lucy-clownfish
Updated Branches:
  refs/heads/master 8c6d95a34 -> 4230a73b4


Fix Clownfish::Test::run_tests

Fix a stupid bug that always ran the same test.


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/28d54ae4
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/28d54ae4
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/28d54ae4

Branch: refs/heads/master
Commit: 28d54ae4f29e19914a2db1202914716bc8881ed1
Parents: 8c6d95a
Author: Nick Wellnhofer <we...@aevum.de>
Authored: Wed Sep 7 15:57:49 2016 +0200
Committer: Nick Wellnhofer <we...@aevum.de>
Committed: Wed Sep 7 15:58:31 2016 +0200

----------------------------------------------------------------------
 runtime/perl/lib/Clownfish/Test.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/28d54ae4/runtime/perl/lib/Clownfish/Test.pm
----------------------------------------------------------------------
diff --git a/runtime/perl/lib/Clownfish/Test.pm b/runtime/perl/lib/Clownfish/Test.pm
index 55aeb94..9ace155 100644
--- a/runtime/perl/lib/Clownfish/Test.pm
+++ b/runtime/perl/lib/Clownfish/Test.pm
@@ -32,7 +32,7 @@ sub run_tests {
     my $suite      = Clownfish::Test::create_test_suite();
 
     return $suite->run_batch(
-        class_name => "Clownfish::Test::TestClass",
+        class_name => $class_name,
         formatter  => $formatter,
     );
 }


[2/7] lucy-clownfish git commit: Fix tests requiring TestUtils

Posted by nw...@apache.org.
Fix tests requiring TestUtils

`buildlib` must be added to @INC.


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/c298a9e6
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/c298a9e6
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/c298a9e6

Branch: refs/heads/master
Commit: c298a9e6e95f255c830230e631f7b503f8aa45da
Parents: 28d54ae
Author: Nick Wellnhofer <we...@aevum.de>
Authored: Wed Sep 7 16:34:25 2016 +0200
Committer: Nick Wellnhofer <we...@aevum.de>
Committed: Wed Sep 7 17:22:06 2016 +0200

----------------------------------------------------------------------
 compiler/perl/t/403-parcel.t         | 1 +
 compiler/perl/t/500-hierarchy.t      | 1 +
 compiler/perl/t/core/403-parcel.t    | 1 +
 compiler/perl/t/core/500-hierarchy.t | 1 +
 4 files changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/c298a9e6/compiler/perl/t/403-parcel.t
----------------------------------------------------------------------
diff --git a/compiler/perl/t/403-parcel.t b/compiler/perl/t/403-parcel.t
index c984af8..c298e55 100644
--- a/compiler/perl/t/403-parcel.t
+++ b/compiler/perl/t/403-parcel.t
@@ -15,6 +15,7 @@
 
 use strict;
 use warnings;
+use lib 'buildlib';
 
 use Clownfish::CFC::Test::TestUtils qw( test_files_dir );
 use Test::More tests => 32;

http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/c298a9e6/compiler/perl/t/500-hierarchy.t
----------------------------------------------------------------------
diff --git a/compiler/perl/t/500-hierarchy.t b/compiler/perl/t/500-hierarchy.t
index a066496..24abbc1 100644
--- a/compiler/perl/t/500-hierarchy.t
+++ b/compiler/perl/t/500-hierarchy.t
@@ -15,6 +15,7 @@
 
 use strict;
 use warnings;
+use lib 'buildlib';
 
 use Test::More tests => 21;
 

http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/c298a9e6/compiler/perl/t/core/403-parcel.t
----------------------------------------------------------------------
diff --git a/compiler/perl/t/core/403-parcel.t b/compiler/perl/t/core/403-parcel.t
index 13a176d..091d3ac 100644
--- a/compiler/perl/t/core/403-parcel.t
+++ b/compiler/perl/t/core/403-parcel.t
@@ -15,6 +15,7 @@
 
 use strict;
 use warnings;
+use lib 'buildlib';
 
 use Clownfish::CFC::Test;
 use Clownfish::CFC::Test::TestUtils qw( test_files_dir );

http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/c298a9e6/compiler/perl/t/core/500-hierarchy.t
----------------------------------------------------------------------
diff --git a/compiler/perl/t/core/500-hierarchy.t b/compiler/perl/t/core/500-hierarchy.t
index 1121369..84e7939 100644
--- a/compiler/perl/t/core/500-hierarchy.t
+++ b/compiler/perl/t/core/500-hierarchy.t
@@ -15,6 +15,7 @@
 
 use strict;
 use warnings;
+use lib 'buildlib';
 
 use Clownfish::CFC::Test;
 use Clownfish::CFC::Test::TestUtils qw( test_files_dir );


[4/7] lucy-clownfish git commit: Regenerate charmonizer.c to fix memory leak

Posted by nw...@apache.org.
Regenerate charmonizer.c to fix memory leak


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/4230a73b
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/4230a73b
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/4230a73b

Branch: refs/heads/master
Commit: 4230a73b4f550a7e5a4a5f27ac5211bf3acdd336
Parents: 03ff7dd
Author: Nick Wellnhofer <we...@aevum.de>
Authored: Wed Sep 7 16:49:15 2016 +0200
Committer: Nick Wellnhofer <we...@aevum.de>
Committed: Wed Sep 7 17:22:44 2016 +0200

----------------------------------------------------------------------
 compiler/common/charmonizer.c | 2 ++
 runtime/common/charmonizer.c  | 2 ++
 2 files changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/4230a73b/compiler/common/charmonizer.c
----------------------------------------------------------------------
diff --git a/compiler/common/charmonizer.c b/compiler/common/charmonizer.c
index 8bafbca..70a6d9c 100644
--- a/compiler/common/charmonizer.c
+++ b/compiler/common/charmonizer.c
@@ -5609,6 +5609,8 @@ chaz_MakeBinary_obj_string(chaz_MakeBinary *self) {
         tmp = chaz_Util_join("", retval, sep, obj_path, NULL);
         free(retval);
         retval = tmp;
+
+        free(obj_path);
     }
 
     return retval;

http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/4230a73b/runtime/common/charmonizer.c
----------------------------------------------------------------------
diff --git a/runtime/common/charmonizer.c b/runtime/common/charmonizer.c
index bb15cd3..a5fca62 100644
--- a/runtime/common/charmonizer.c
+++ b/runtime/common/charmonizer.c
@@ -5609,6 +5609,8 @@ chaz_MakeBinary_obj_string(chaz_MakeBinary *self) {
         tmp = chaz_Util_join("", retval, sep, obj_path, NULL);
         free(retval);
         retval = tmp;
+
+        free(obj_path);
     }
 
     return retval;


[3/7] lucy-clownfish git commit: Fix memory leak in runtime tests

Posted by nw...@apache.org.
Fix memory leak in runtime tests


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/da8107e5
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/da8107e5
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/da8107e5

Branch: refs/heads/master
Commit: da8107e543e84adc29977bd3c4ee30b21040a7f8
Parents: 65bf8ef
Author: Nick Wellnhofer <we...@aevum.de>
Authored: Wed Sep 7 16:48:36 2016 +0200
Committer: Nick Wellnhofer <we...@aevum.de>
Committed: Wed Sep 7 17:22:44 2016 +0200

----------------------------------------------------------------------
 runtime/test/Clownfish/Test/TestCharBuf.c | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/da8107e5/runtime/test/Clownfish/Test/TestCharBuf.c
----------------------------------------------------------------------
diff --git a/runtime/test/Clownfish/Test/TestCharBuf.c b/runtime/test/Clownfish/Test/TestCharBuf.c
index 9cf5bbf..ec5072a 100644
--- a/runtime/test/Clownfish/Test/TestCharBuf.c
+++ b/runtime/test/Clownfish/Test/TestCharBuf.c
@@ -132,6 +132,8 @@ test_roundtrip(TestBatchRunner *runner) {
     else {
         FAIL(runner, "Failed round trip at 0x%04X", (unsigned)code_point);
     }
+
+    DECREF(cb);
 }
 
 typedef struct {


[5/7] lucy-clownfish git commit: Fix memory leaks in CFC tests

Posted by nw...@apache.org.
Fix memory leaks in CFC tests


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/ad5ba99c
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/ad5ba99c
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/ad5ba99c

Branch: refs/heads/master
Commit: ad5ba99cf66f8be6b9ca1a5db6db3b74c141abf3
Parents: c298a9e
Author: Nick Wellnhofer <we...@aevum.de>
Authored: Wed Sep 7 16:37:10 2016 +0200
Committer: Nick Wellnhofer <we...@aevum.de>
Committed: Wed Sep 7 17:22:44 2016 +0200

----------------------------------------------------------------------
 compiler/src/CFCTestHierarchy.c | 1 +
 compiler/src/CFCTestParcel.c    | 2 ++
 compiler/src/CFCUtil.c          | 4 +++-
 3 files changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/ad5ba99c/compiler/src/CFCTestHierarchy.c
----------------------------------------------------------------------
diff --git a/compiler/src/CFCTestHierarchy.c b/compiler/src/CFCTestHierarchy.c
index 6fa1aae..1b1a568 100644
--- a/compiler/src/CFCTestHierarchy.c
+++ b/compiler/src/CFCTestHierarchy.c
@@ -323,6 +323,7 @@ S_run_clash_tests(CFCTest *test) {
     rmdir(AUTOGEN);
 
     FREEMEM(cfbase_path);
+    FREEMEM(cfinc_path);
     FREEMEM(cfclash_file_path);
     FREEMEM(cfclash_class_path);
     FREEMEM(cfclash_bar_path);

http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/ad5ba99c/compiler/src/CFCTestParcel.c
----------------------------------------------------------------------
diff --git a/compiler/src/CFCTestParcel.c b/compiler/src/CFCTestParcel.c
index 878ab02..5306182 100644
--- a/compiler/src/CFCTestParcel.c
+++ b/compiler/src/CFCTestParcel.c
@@ -165,6 +165,8 @@ S_run_basic_tests(CFCTest *test) {
     CFCBase_decref((CFCBase*)included_foo);
     CFCBase_decref((CFCBase*)file_spec);
     CFCBase_decref((CFCBase*)foo);
+    CFCBase_decref((CFCBase*)major);
+    CFCBase_decref((CFCBase*)version);
     CFCParcel_reap_singletons();
 }
 

http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/ad5ba99c/compiler/src/CFCUtil.c
----------------------------------------------------------------------
diff --git a/compiler/src/CFCUtil.c b/compiler/src/CFCUtil.c
index edc9c17..6c0f224 100644
--- a/compiler/src/CFCUtil.c
+++ b/compiler/src/CFCUtil.c
@@ -713,7 +713,9 @@ CFCUtil_rethrow(char *error) {
         longjmp(*current_env, 1);
     }
     else {
-        croak("%s", error);
+        SV *error_sv = newSVpv(error, 0);
+        free(error);
+        croak_sv(sv_2mortal(error_sv));
     }
 }
 


[7/7] lucy-clownfish git commit: Fix memory leak in CFC

Posted by nw...@apache.org.
Fix memory leak in CFC


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/65bf8eff
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/65bf8eff
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/65bf8eff

Branch: refs/heads/master
Commit: 65bf8eff8d543658033499b54744d8983d12a532
Parents: ad5ba99
Author: Nick Wellnhofer <we...@aevum.de>
Authored: Wed Sep 7 16:43:12 2016 +0200
Committer: Nick Wellnhofer <we...@aevum.de>
Committed: Wed Sep 7 17:22:44 2016 +0200

----------------------------------------------------------------------
 compiler/src/CFCParcel.c | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/65bf8eff/compiler/src/CFCParcel.c
----------------------------------------------------------------------
diff --git a/compiler/src/CFCParcel.c b/compiler/src/CFCParcel.c
index 25cc77c..409044c 100644
--- a/compiler/src/CFCParcel.c
+++ b/compiler/src/CFCParcel.c
@@ -302,6 +302,7 @@ S_new_from_json(const char *json, CFCFileSpec *file_spec) {
         S_set_prereqs(self, prereqs, path);
     }
     CFCBase_decref((CFCBase*)version);
+    CFCBase_decref((CFCBase*)major_version);
 
     CFCJson_destroy(parsed);
     return self;


[6/7] lucy-clownfish git commit: Update valgrind suppressions

Posted by nw...@apache.org.
Update valgrind suppressions


Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/03ff7ddf
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/03ff7ddf
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/03ff7ddf

Branch: refs/heads/master
Commit: 03ff7ddfd5c113e9d35e918d4eb7c5ca94b8e6df
Parents: da8107e
Author: Nick Wellnhofer <we...@aevum.de>
Authored: Wed Sep 7 16:49:01 2016 +0200
Committer: Nick Wellnhofer <we...@aevum.de>
Committed: Wed Sep 7 17:22:44 2016 +0200

----------------------------------------------------------------------
 devel/conf/cfruntime-perl.supp | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/03ff7ddf/devel/conf/cfruntime-perl.supp
----------------------------------------------------------------------
diff --git a/devel/conf/cfruntime-perl.supp b/devel/conf/cfruntime-perl.supp
index 55dab07..6d1b907 100644
--- a/devel/conf/cfruntime-perl.supp
+++ b/devel/conf/cfruntime-perl.supp
@@ -22,6 +22,14 @@
 }
 
 {
+   <boot_Clownfish__Test>
+   Memcheck:Leak
+   ...
+   fun:boot_Clownfish__Test
+   ...
+}
+
+{
    <XS_DynaLoader_dl_load_file>
    Memcheck:Leak
    ...
@@ -37,3 +45,11 @@
    ...
 }
 
+{
+   <cfish_Class_add_alias_to_registry>
+   Memcheck:Leak
+   ...
+   fun:cfish_Class_add_alias_to_registry
+   ...
+}
+