You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tubemq.apache.org by GitBox <gi...@apache.org> on 2021/01/05 07:28:24 UTC

[GitHub] [incubator-tubemq] EMsnap opened a new pull request #378: [TUBEMQ-465] add new feature - copy offset from one group to another

EMsnap opened a new pull request #378:
URL: https://github.com/apache/incubator-tubemq/pull/378


   [TUBEMQ-465] add new feature - copy offset from one group to another


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] yuanboliu commented on pull request #378: [TUBEMQ-465] add new feature - copy offset from one group to another

Posted by GitBox <gi...@apache.org>.
yuanboliu commented on pull request #378:
URL: https://github.com/apache/incubator-tubemq/pull/378#issuecomment-754577056


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] EMsnap commented on a change in pull request #378: [TUBEMQ-465] add new feature - copy offset from one group to another

Posted by GitBox <gi...@apache.org>.
EMsnap commented on a change in pull request #378:
URL: https://github.com/apache/incubator-tubemq/pull/378#discussion_r551866035



##########
File path: tubemq-manager/src/main/java/org/apache/tubemq/manager/controller/topic/TopicWebController.java
##########
@@ -155,11 +156,31 @@ public TubeMQResult cloneTopic(@RequestBody CloneTopicReq req) throws Exception
      * @return
      * @throws Exception
      */
+    @PostMapping("/query/config")
     public @ResponseBody String queryTopicConfig(
         @RequestParam Map<String, String> req) throws Exception {
         String url = masterUtils.getQueryUrl(req);
         return queryMaster(url);
     }
 
 
+    /**
+     *

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] gosonzhang merged pull request #378: [TUBEMQ-465] add new feature - copy offset from one group to another

Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #378:
URL: https://github.com/apache/incubator-tubemq/pull/378


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] yuanboliu commented on a change in pull request #378: [TUBEMQ-465] add new feature - copy offset from one group to another

Posted by GitBox <gi...@apache.org>.
yuanboliu commented on a change in pull request #378:
URL: https://github.com/apache/incubator-tubemq/pull/378#discussion_r551850390



##########
File path: tubemq-manager/src/main/java/org/apache/tubemq/manager/controller/topic/TopicWebController.java
##########
@@ -155,11 +156,31 @@ public TubeMQResult cloneTopic(@RequestBody CloneTopicReq req) throws Exception
      * @return
      * @throws Exception
      */
+    @PostMapping("/query/config")
     public @ResponseBody String queryTopicConfig(
         @RequestParam Map<String, String> req) throws Exception {
         String url = masterUtils.getQueryUrl(req);
         return queryMaster(url);
     }
 
 
+    /**
+     *

Review comment:
       add some comments here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org