You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2013/11/11 23:08:58 UTC
Review Request 15431: [HELIX-297] Support old rebalancer for backward
compatibility
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15431/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-297
Repository: helix-git
Description
-------
commit 7dac0debfc9742a2bdb51ba9cac9ca9b68133266
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Mon Nov 11 14:06:13 2013 -0800
[HELIX-297] Support old rebalancer for backward compatibility
:100644 100644 69c379a... 5209e2c... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java
:000000 100644 0000000... 4be3481... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/FallbackRebalancer.java
:100644 100644 a0ee1c1... d1ed404... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java
:100644 100644 933bf78... 6198133... M helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
:100644 100644 3dd3b81... aee4c05... M helix-core/src/main/java/org/apache/helix/controller/stages/ResourceCurrentState.java
:100644 100644 1d694ab... 6a3e054... M helix-core/src/main/java/org/apache/helix/model/Partition.java
:100644 100644 1544514... 437aca6... M helix-core/src/main/java/org/apache/helix/model/Resource.java
:000000 100644 0000000... 71205b3... A helix-core/src/test/java/org/apache/helix/integration/TestUserDefRebalancerCompatibility.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 69c379a
helix-core/src/main/java/org/apache/helix/controller/rebalancer/FallbackRebalancer.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java a0ee1c1
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 933bf78
helix-core/src/main/java/org/apache/helix/controller/stages/ResourceCurrentState.java 3dd3b81
helix-core/src/main/java/org/apache/helix/model/Partition.java 1d694ab
helix-core/src/main/java/org/apache/helix/model/Resource.java 1544514
helix-core/src/test/java/org/apache/helix/integration/TestUserDefRebalancerCompatibility.java PRE-CREATION
Diff: https://reviews.apache.org/r/15431/diff/
Testing
-------
All tests pass locally.
Thanks,
Kanak Biscuitwala
Re: Review Request 15431: [HELIX-297] Support old rebalancer for backward
compatibility
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15431/#review28703
-----------------------------------------------------------
Ship it!
Ship It!
- Zhen Zhang
On Nov. 11, 2013, 10:08 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15431/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2013, 10:08 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-297
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 7dac0debfc9742a2bdb51ba9cac9ca9b68133266
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Mon Nov 11 14:06:13 2013 -0800
>
> [HELIX-297] Support old rebalancer for backward compatibility
>
> :100644 100644 69c379a... 5209e2c... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java
> :000000 100644 0000000... 4be3481... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/FallbackRebalancer.java
> :100644 100644 a0ee1c1... d1ed404... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java
> :100644 100644 933bf78... 6198133... M helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
> :100644 100644 3dd3b81... aee4c05... M helix-core/src/main/java/org/apache/helix/controller/stages/ResourceCurrentState.java
> :100644 100644 1d694ab... 6a3e054... M helix-core/src/main/java/org/apache/helix/model/Partition.java
> :100644 100644 1544514... 437aca6... M helix-core/src/main/java/org/apache/helix/model/Resource.java
> :000000 100644 0000000... 71205b3... A helix-core/src/test/java/org/apache/helix/integration/TestUserDefRebalancerCompatibility.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 69c379a
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/FallbackRebalancer.java PRE-CREATION
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java a0ee1c1
> helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 933bf78
> helix-core/src/main/java/org/apache/helix/controller/stages/ResourceCurrentState.java 3dd3b81
> helix-core/src/main/java/org/apache/helix/model/Partition.java 1d694ab
> helix-core/src/main/java/org/apache/helix/model/Resource.java 1544514
> helix-core/src/test/java/org/apache/helix/integration/TestUserDefRebalancerCompatibility.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/15431/diff/
>
>
> Testing
> -------
>
> All tests pass locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>