You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2021/12/07 19:14:25 UTC

[GitHub] [daffodil] tuxji commented on a change in pull request #698: Updated constructor that only requires cause exception as an argument…

tuxji commented on a change in pull request #698:
URL: https://github.com/apache/daffodil/pull/698#discussion_r764290048



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/SAXInfosetInputter.scala
##########
@@ -207,7 +207,8 @@ class SAXInfosetInputter(
       }
     } catch {
       case e: Exception => {
-        batchedInfosetEvents(currentIndex).causeError = One(new DaffodilUnhandledSAXException(e.getMessage, e))
+        batchedInfosetEvents(currentIndex).causeError = One(new DaffodilUnhandledSAXException(e))
+

Review comment:
       Line 210 isn't covered by any test, which causes the new constructor to be uncovered too.  
   
   Does anyone have any idea how to write a test that would cause an exception to escape from dp.unparse at line 202 without being wrapped in an unparseResult.isError?  
   
   @mphyo21, if you want to practice your IDE navigation skills, please use your IDE's Go To functionality to find out which code implements the dp.unparse call at line 202 and inform us so we can check if there is any way a test could make an exception escape from that code.  If the IDE can't tell you which code implements dp.unparse, you can practice your IDE debugging skills instead - set a breakpoint at line 202, run a test from your IDE, step into the dp.unparse call, and report back to us which code implements that call.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org