You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2009/04/06 18:28:13 UTC
[jira] Created: (WICKET-2213) Remove FormComponent persistence
Remove FormComponent persistence
--------------------------------
Key: WICKET-2213
URL: https://issues.apache.org/jira/browse/WICKET-2213
Project: Wicket
Issue Type: Improvement
Components: wicket
Reporter: Juergen Donnerstag
Fix For: 1.5-M1
At the very beginning of Wicket we introduced FormComponent.setPersistence with the idea to make creating Login panel very easy. Basically Wicket would deal with the Cookie handling for the login details. Now some years later I think it is evident that this feature is not very useful:
- it basically is used for login panels only
- even in our examples Password.setPersistence is false which means that "rememberMe" doesn't really work. Only the user name is stored in a Cookie
- forcing formComponent.getPageRelativePath() as the Cookie name is quite restrictive
- you can not combine username and password into a single Cookie and e.g. decrypt it for safety reasons
I'd like to propose to remove all that code from core.
I've attached a patch for 1.4RC2 which remove that code and I updated SignInPanel and the example to show how easy it still is.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-2213) Remove FormComponent persistence
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag reassigned WICKET-2213:
------------------------------------------
Assignee: Juergen Donnerstag
> Remove FormComponent persistence
> --------------------------------
>
> Key: WICKET-2213
> URL: https://issues.apache.org/jira/browse/WICKET-2213
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Juergen Donnerstag
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M1
>
> Attachments: wicket-2213.patch
>
>
> At the very beginning of Wicket we introduced FormComponent.setPersistence with the idea to make creating Login panel very easy. Basically Wicket would deal with the Cookie handling for the login details. Now some years later I think it is evident that this feature is not very useful:
> - it basically is used for login panels only
> - even in our examples Password.setPersistence is false which means that "rememberMe" doesn't really work. Only the user name is stored in a Cookie
> - forcing formComponent.getPageRelativePath() as the Cookie name is quite restrictive
> - you can not combine username and password into a single Cookie and e.g. decrypt it for safety reasons
> I'd like to propose to remove all that code from core.
> I've attached a patch for 1.4RC2 which remove that code and I updated SignInPanel and the example to show how easy it still is.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2213) Remove FormComponent persistence
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag updated WICKET-2213:
---------------------------------------
Attachment: wicket-2213.patch
> Remove FormComponent persistence
> --------------------------------
>
> Key: WICKET-2213
> URL: https://issues.apache.org/jira/browse/WICKET-2213
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Juergen Donnerstag
> Fix For: 1.5-M1
>
> Attachments: wicket-2213.patch
>
>
> At the very beginning of Wicket we introduced FormComponent.setPersistence with the idea to make creating Login panel very easy. Basically Wicket would deal with the Cookie handling for the login details. Now some years later I think it is evident that this feature is not very useful:
> - it basically is used for login panels only
> - even in our examples Password.setPersistence is false which means that "rememberMe" doesn't really work. Only the user name is stored in a Cookie
> - forcing formComponent.getPageRelativePath() as the Cookie name is quite restrictive
> - you can not combine username and password into a single Cookie and e.g. decrypt it for safety reasons
> I'd like to propose to remove all that code from core.
> I've attached a patch for 1.4RC2 which remove that code and I updated SignInPanel and the example to show how easy it still is.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2213) Remove FormComponent persistence
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-2213.
----------------------------------------
Resolution: Fixed
fixed
> Remove FormComponent persistence
> --------------------------------
>
> Key: WICKET-2213
> URL: https://issues.apache.org/jira/browse/WICKET-2213
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Juergen Donnerstag
> Assignee: Juergen Donnerstag
> Fix For: 1.5-M1
>
> Attachments: wicket-2213.patch
>
>
> At the very beginning of Wicket we introduced FormComponent.setPersistence with the idea to make creating Login panel very easy. Basically Wicket would deal with the Cookie handling for the login details. Now some years later I think it is evident that this feature is not very useful:
> - it basically is used for login panels only
> - even in our examples Password.setPersistence is false which means that "rememberMe" doesn't really work. Only the user name is stored in a Cookie
> - forcing formComponent.getPageRelativePath() as the Cookie name is quite restrictive
> - you can not combine username and password into a single Cookie and e.g. decrypt it for safety reasons
> I'd like to propose to remove all that code from core.
> I've attached a patch for 1.4RC2 which remove that code and I updated SignInPanel and the example to show how easy it still is.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.