You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by navis <gi...@git.apache.org> on 2015/10/16 10:56:59 UTC
[GitHub] phoenix pull request: PHOENIX-2304 NullPointerException when using...
GitHub user navis opened a pull request:
https://github.com/apache/phoenix/pull/121
PHOENIX-2304 NullPointerException when using an index and a char array
An NPE occurs when Phoenix attempts to retrieve a char array from an index. Retrieving other columns in the table is unaffected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/navis/phoenix PHOENIX-2304
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 0f39a2f24d860b0803ffd2936c54f4fc0875966b
Author: navis.ryu <na...@apache.org>
Date: 2015-10-16T08:52:03Z
PHOENIX-2304 NullPointerException when using an index and a char array
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2304 NullPointerException when using...
Posted by navis <gi...@git.apache.org>.
Github user navis commented on the pull request:
https://github.com/apache/phoenix/pull/121#issuecomment-149186165
Made two version of patches (a69735b and a20e123).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2304 NullPointerException when using...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/121#discussion_r42262797
--- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/ColumnDef.java ---
@@ -78,7 +79,7 @@
}
this.isNull = isNull;
- if (this.dataType == PChar.INSTANCE) {
+ if (this.dataType == PChar.INSTANCE || this.dataType == PCharArray.INSTANCE) {
--- End diff --
I'd be curious if BINARY type would require the same fix. A more general check would be:
if (this.dataType.isFixedWidth()) {
along with generalizing the error messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2304 NullPointerException when using...
Posted by navis <gi...@git.apache.org>.
Github user navis closed the pull request at:
https://github.com/apache/phoenix/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2304 NullPointerException when using...
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/121#issuecomment-148763881
Thanks for the pull request, @navis. Would you mind including a unit test as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---