You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/04/11 14:02:59 UTC
Review Request 58354: Handle caching of topologies,
configs and metadata
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20734
https://issues.apache.org/jira/browse/AMBARI-20734
Repository: ambari
Description
-------
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733
ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9
ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8
ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py c7ad082
ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 44afc48
ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f
ambari-agent/src/main/python/ambari_agent/security.py 32ad556
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py b0f3a16
Diff: https://reviews.apache.org/r/58354/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58354: Handle caching of topologies,
configs and metadata
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/#review171597
-----------------------------------------------------------
Fix it, then Ship it!
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py
Lines 91 (patched)
<https://reviews.apache.org/r/58354/#comment244542>
Add doc
ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py
Lines 29 (patched)
<https://reviews.apache.org/r/58354/#comment244541>
Add doc
ambari-agent/src/main/python/ambari_agent/listeners/__init__.py
Lines 26 (patched)
<https://reviews.apache.org/r/58354/#comment244543>
Add doc
- Alejandro Fernandez
On April 11, 2017, 2:04 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58354/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 2:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-20734
> https://issues.apache.org/jira/browse/AMBARI-20734
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733
> ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9
> ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947
> ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8
> ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py c7ad082
> ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 44afc48
> ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f
> ambari-agent/src/main/python/ambari_agent/security.py 32ad556
> ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py b0f3a16
>
>
> Diff: https://reviews.apache.org/r/58354/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58354: Handle caching of topologies,
configs and metadata
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/#review171562
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On \u041a\u0432\u0456\u0442\u0435\u043d\u044c 11, 2017, 5:04 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58354/
> -----------------------------------------------------------
>
> (Updated \u041a\u0432\u0456\u0442\u0435\u043d\u044c 11, 2017, 5:04 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-20734
> https://issues.apache.org/jira/browse/AMBARI-20734
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733
> ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9
> ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947
> ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8
> ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py c7ad082
> ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 44afc48
> ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f
> ambari-agent/src/main/python/ambari_agent/security.py 32ad556
> ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py b0f3a16
>
>
> Diff: https://reviews.apache.org/r/58354/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58354: Handle caching of topologies,
configs and metadata
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/#review171694
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/security.py
Line 104 (original), 104 (patched)
<https://reviews.apache.org/r/58354/#comment244731>
a test class which will be replace soon. By the one working with server. Not adding doc to it.
- Andrew Onischuk
On April 12, 2017, 9:09 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58354/
> -----------------------------------------------------------
>
> (Updated April 12, 2017, 9:09 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-20734
> https://issues.apache.org/jira/browse/AMBARI-20734
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733
> ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py 61fdf94
> ambari-agent/src/main/python/ambari_agent/ClusterMetadataCache.py 4859b3f
> ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py 19313c5
> ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9
> ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947
> ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8
> ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py c7ad082
> ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 44afc48
> ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f
> ambari-agent/src/main/python/ambari_agent/security.py 32ad556
> ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py b0f3a16
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json PRE-CREATION
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_response.json 779f139
>
>
> Diff: https://reviews.apache.org/r/58354/diff/4/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 58354: Handle caching of topologies,
configs and metadata
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/
-----------------------------------------------------------
(Updated April 12, 2017, 9:09 a.m.)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20734
https://issues.apache.org/jira/browse/AMBARI-20734
Repository: ambari
Description
-------
.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733
ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py 61fdf94
ambari-agent/src/main/python/ambari_agent/ClusterMetadataCache.py 4859b3f
ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py 19313c5
ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9
ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8
ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py c7ad082
ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 44afc48
ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f
ambari-agent/src/main/python/ambari_agent/security.py 32ad556
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py b0f3a16
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json PRE-CREATION
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_response.json 779f139
Diff: https://reviews.apache.org/r/58354/diff/4/
Changes: https://reviews.apache.org/r/58354/diff/3-4/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58354: Handle caching of topologies,
configs and metadata
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/
-----------------------------------------------------------
(Updated April 12, 2017, 9:09 a.m.)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20734
https://issues.apache.org/jira/browse/AMBARI-20734
Repository: ambari
Description
-------
.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733
ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py 61fdf94
ambari-agent/src/main/python/ambari_agent/ClusterMetadataCache.py 4859b3f
ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py 19313c5
ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9
ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8
ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py c7ad082
ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 44afc48
ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f
ambari-agent/src/main/python/ambari_agent/security.py 32ad556
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py b0f3a16
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json PRE-CREATION
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_response.json 779f139
Diff: https://reviews.apache.org/r/58354/diff/3/
Changes: https://reviews.apache.org/r/58354/diff/2-3/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58354: Handle caching of topologies,
configs and metadata
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58354/
-----------------------------------------------------------
(Updated April 11, 2017, 2:04 p.m.)
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20734
https://issues.apache.org/jira/browse/AMBARI-20734
Repository: ambari
Description (updated)
-------
.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterCache.py 1986733
ambari-agent/src/main/python/ambari_agent/Constants.py 0ff9eb9
ambari-agent/src/main/python/ambari_agent/Controller.py 4d81947
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 2c2f9d8
ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/MetadataEventListener.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py c7ad082
ambari-agent/src/main/python/ambari_agent/listeners/TopologyEventListener.py 44afc48
ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 8cfcc3f
ambari-agent/src/main/python/ambari_agent/security.py 32ad556
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py b0f3a16
Diff: https://reviews.apache.org/r/58354/diff/2/
Changes: https://reviews.apache.org/r/58354/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk