You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ko...@apache.org on 2022/01/18 02:25:52 UTC

[couchdb] 01/02: See if try/catch/finally is causing UX troubles

This is an automated email from the ASF dual-hosted git repository.

kocolosk pushed a commit to branch jenkins-dynamic-matrix
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 7aa914a52c5a9ceb304bba0755d009b6d15e0fdd
Author: Adam Kocoloski <ko...@apache.org>
AuthorDate: Mon Jan 17 20:57:22 2022 -0500

    See if try/catch/finally is causing UX troubles
---
 build-aux/Jenkinsfile.full | 60 +++++++++++++++++++++++-----------------------
 1 file changed, 30 insertions(+), 30 deletions(-)

diff --git a/build-aux/Jenkinsfile.full b/build-aux/Jenkinsfile.full
index 9a22eeb..7355d6c 100644
--- a/build-aux/Jenkinsfile.full
+++ b/build-aux/Jenkinsfile.full
@@ -133,7 +133,7 @@ def generateNativeStage(platform) {
     stage("${meta[platform].name} - build & test") {
       node(platform) {
         timeout(time: 90, unit: "MINUTES") {
-          try {
+          // try {
             // deleteDir is OK here because we're not inside of a Docker container!
             deleteDir()
             unstash 'tarball'
@@ -155,19 +155,19 @@ def generateNativeStage(platform) {
                 sh '$MAKE mango-test'
               }
             }
-          }
-          catch (err) {
-            echo "Build failed: {$err}"
-            dir( "${platform}/build/couchdb" ) {
-              sh 'make build-report'
-            }
-          }
-          finally {
+          // }
+          // catch (err) {
+          //   echo "Build failed: {$err}"
+          //   dir( "${platform}/build/couchdb" ) {
+          //     sh 'make build-report'
+          //   }
+          // }
+          // finally {
             junit '**/.eunit/*.xml, **/_build/*/lib/couchdbtest/*.xml, **/src/mango/nosetests.xml, **/test/javascript/junit.xml'
             sh 'killall -9 beam.smp || true'
             dir( "${COUCHDB_IO_LOG_DIR}" ) { deleteDir() }
             deleteDir()
-          }
+          // }
         }
       }
     }
@@ -185,7 +185,7 @@ def generateContainerStage(platform) {
               withEnv(['PLATFORM='+platform]) {
                 stage("${meta[platform].name} - build & test") {
                   sh( script: 'rm -rf apache-couchdb-*', label: 'Clean workspace' )
-                  try {
+                  // try {
                     unstash 'tarball'
                     sh( script: unpack, label: 'Unpack tarball' )
                     dir( "${platform}/build/couchdb" ) {
@@ -196,37 +196,37 @@ def generateContainerStage(platform) {
                       sh 'make exunit'
                       sh 'make mango-test'
                     }
-                  }
-                  catch (err) {
-                    echo "Build failed: {$err}"
-                    sh 'ls -l ${WORKSPACE}'
-                    dir( "${platform}/build/couchdb" ) {
-                      sh 'pwd; ls -l'
-                      sh 'make build-report'
-                    }
-                  }
-                  finally {
+                  // }
+                  // catch (err) {
+                  //   echo "Build failed: {$err}"
+                  //   sh 'ls -l ${WORKSPACE}'
+                  //   dir( "${platform}/build/couchdb" ) {
+                  //     sh 'pwd; ls -l'
+                  //     sh 'make build-report'
+                  //   }
+                  // }
+                  // finally {
                     junit '**/.eunit/*.xml, **/_build/*/lib/couchdbtest/*.xml, **/src/mango/nosetests.xml, **/test/javascript/junit.xml'
                     dir( "${COUCHDB_IO_LOG_DIR}" ) { deleteDir() }
                     deleteDir()
-                  }
+                  // }
                 }
 
                 stage("${meta[platform].name} - package") {
-                  try {
+                  // try {
                     sh 'pwd; ls -l'
                     unstash 'tarball'
                     sh( script: make_packages, label: 'Build packages' )
                     sh( script: cleanup_and_save, label: 'Stage package artifacts for archival' )
                     archiveArtifacts artifacts: 'pkgs/**', fingerprint: true, onlyIfSuccessful: true
-                  }
-                  catch (err) {
-                    echo "Packaging failed: {$err}"
-                    sh 'ls -l ${WORKSPACE}'
-                  }
-                  finally {
+                  // }
+                  // catch (err) {
+                  //   echo "Packaging failed: {$err}"
+                  //   sh 'ls -l ${WORKSPACE}'
+                  // }
+                  // finally {
                     deleteDir()
-                  }
+                  // }
                 }
               }
             }