You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/21 14:29:40 UTC

[GitHub] [incubator-devlake] e2corporation opened a new pull request, #3157: refactor: webpack & eslint - disable autofix on startup compile

e2corporation opened a new pull request, #3157:
URL: https://github.com/apache/incubator-devlake/pull/3157

   ### ⚠️ Config-UI / **Webpack**
   
   - [ ] `Refactor` Disable ESLint _autofix_ on Webpack startup
   
   This PR turns **OFF** the **ESLint** _autofix_ setting for **Webpack** which was appropriate during early stages of development. With recent changes to the Global ESLint  & adopting Prettier configuration, however, this creates an undesirable situation for developers with older versions of `main` when trying to rebase or update, Webpack's ESLint's auto-fix will try to enforce the new standards while the server is starting or re-compile if it is running already running, which will automatically try to write changes to local files.
   
   ```js
   ...
   ...
         new ESLintPlugin({
           // Do NOT auto-fix w/ eslint on webpack startup!
           fix: false,
           context: path.resolve(__dirname, './'),
           exclude: ['dist', 'packages', 'cypress', 'config', 'node_modules']
         }),
   ...
   ...
   ```
   
   ### Does this close any open issues?
   Closes #3152
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh merged pull request #3157: refactor: webpack & eslint - disable autofix on startup compile

Posted by GitBox <gi...@apache.org>.
klesh merged PR #3157:
URL: https://github.com/apache/incubator-devlake/pull/3157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mintsweet commented on pull request #3157: refactor: webpack & eslint - disable autofix on startup compile

Posted by GitBox <gi...@apache.org>.
mintsweet commented on PR #3157:
URL: https://github.com/apache/incubator-devlake/pull/3157#issuecomment-1254393751

   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org