[GitHub] [airflow] cdibble commented on pull request #15659: Fix log persistence with KubernetesExecutor

[GitBox <gi...@apache.org>]

cdibble commented on pull request #15659:
URL: https://github.com/apache/airflow/pull/15659#issuecomment-832305777


   I tried to apply this with `helm upgrade` to my k8s deployment on EKS (AWS) and it failed to upgrade with the following output, which looks to be mostly just a dump of the `pod-template-file.kubernetes-helm-yaml` file. Let me know if there is some other info I can provide.
   
   ```
   Error: UPGRADE FAILED: template: airflow/templates/webserver/webserver-deployment.yaml:60:36: executing "airflow/templates/webserver/webserver-deployment.yaml" at <include (print $.Template.BasePath "/configmaps/configmap.yaml") .>: error calling include: template: airflow/templates/configmaps/configmap.yaml:58:3: executing "airflow/templates/configmaps/configmap.yaml" at <tpl (.Files.Get "files/pod-template-file.kubernetes-helm-yaml") .>: error calling tpl: error during tpl function execution for "# Licensed to the Apache Software Foundation (ASF) under one\n# or more contributor license agreements.  See the NOTICE file\n# distributed with this work for additional information\n# regarding copyright ownGIT-STASH(1)                                                               Git Manual                                                               GIT-STASH(1)
   ership.  The ASF licenses this file\n# to you under the Apache License, Version 2.0 (the\n# \"License\"); you may not use this file except in compliance\n# with the License.  You may obtain a copy of the License at\n#\n#   http://www.apache.org/licenses/LICENSE-2.0\n#\n# Unless required by applicable law or agreed to in writing,\n# software distributed under the License is distributed on an\n# \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n# KIND, either express or implied.  See the License for the\n# specific language governing permissions and limitations\n# under the License.\n---\napiVersion: v1\nkind: Pod\nmetadata:\n  name: dummy-name\nspec:\n{{- if and .Values.dags.gitSync.enabled (not .Values.dags.persistence.enabled) }}\n  initContainers:\n{{- include \"git_sync_container\" (dict \"Values\" .Values \"is_init\" \"true\") | indent 4 }}\n{{- end }}\n  containers:\n    - args: []\n      command: []\n      envFrom:\n      {{- include \"custom_airflow_environment_from
 \" . | default \"\\n  []\" | indent 6 }}\n      env:\n        - name: AIRFLOW__CORE__EXECUTOR\n          value: LocalExecutor\n{{- include \"standard_airflow_environment\" . | indent 6}}\n{{- include \"custom_airflow_environment\" . | indent 6 }}\n      image: {{ template \"pod_template_image\" . }}\n      imagePullPolicy: {{ .Values.images.airflow.pullPolicy }}\n      name: base\n      ports: []\n      volumeMounts:\n        - mountPath: {{ template \"airflow_logs\" . }}\n          name: logs\n        - name: config\n          mountPath: {{ template \"airflow_config_path\" . }}\n          subPath: airflow.cfg\n          readOnly: true\n{{- if .Values.scheduler.airflowLocalSettings }}\n        - name: config\n          mountPath: {{ template \"airflow_local_setting_path\" . }}\n          subPath: airflow_local_settings.py\n          readOnly: true\n{{- end }}\n{{- if .Values.dags.gitSync.knownHosts }}\n        - mountPath: /etc/git-secret/known_hosts\n          name: git-sync-known-
 hosts\n          subPath: known_hosts\n{{- end }}\n{{- if .Values.dags.gitSync.sshKeySecret }}\n        - mountPath: /etc/git-secret/ssh\n          name: git-sync-ssh-key\n          subPath: ssh\n{{- end }}\n{{- if or .Values.dags.gitSync.enabled .Values.dags.persistence.enabled }}\n        - mountPath: {{ include \"airflow_dags_mount_path\" . }}\n          name: dags\n          readOnly: true\n{{- end }}\n{{- if .Values.workers.extraVolumeMounts }}\n{{ toYaml .Values.workers.extraVolumeMounts | indent 8 }}\n{{- end }}\n  hostNetwork: false\n  {{- if or .Values.registry.secretName .Values.registry.connection }}\n  imagePullSecrets:\n    - name: {{ template \"registry_secret\" . }}\n  {{- end }}\n  restartPolicy: Never\n  securityContext:\n    runAsUser: {{ .Values.uid }}\n    fsGroup: {{ .Values.gid }}\n  nodeSelector: {{ toYaml .Values.nodeSelector | nindent 4 }}\n  affinity: {{ toYaml .Values.affinity | nindent 4 }}\n  tolerations: {{ toYaml .Values.tolerations | nindent 4 }}\n  s
 erviceAccountName: {{ include \"worker.serviceAccountName\" . }}\n  volumes:\n  {{- if .Values.dags.persistence.enabled }}\n  - name: dags\n    persistentVolumeClaim:\n      claimName: {{ template \"airflow_dags_volume_claim\" . }}\n  {{- else if .Values.dags.gitSync.enabled }}\n  - name: dags\n    emptyDir: {}\n  {{- end }}\n  {{- if and  .Values.dags.gitSync.enabled  .Values.dags.gitSync.sshKeySecret }}\n{{- include \"git_sync_ssh_key_volume\" . | indent 2 }}\n  {{- end }}\n{{- if .Values.logs.persistence.enabled }}\n  - name: logs\n    persistentVolumeClaim:\n      claimName: {{ template \"airflow_logs_volume_claim\" . }}\n{{- else }}\n  - emptyDir: {}\n    name: logs\n{{- end }}\n{{- if .Values.dags.gitSync.knownHosts }}\n  - configMap:\n      defaultMode: 288\n      name: {{ include \"airflow_config\" . }}\n    name: git-sync-known-hosts\n{{- end }}\n  - configMap:\n      name: {{ include \"airflow_config\" . }}\n    name: config\n{{- if .Values.workers.extraVolumes }}\n{{ toYa
 ml .Values.workers.extraVolumes | indent 2 }}\n{{- end }}\n": template: airflow/templates/webserver/webserver-deployment.yaml:84:25: executing "airflow/templates/webserver/webserver-deployment.yaml" at <include "worker.serviceAccountName" .>: error calling include: template: no template "worker.serviceAccountName" associated with template "gotpl"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org