You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2012/12/29 16:34:50 UTC
svn commit: r1426773 - in /subversion/trunk: subversion/bindings/cxxhl/src/
subversion/libsvn_client/ subversion/libsvn_fs_fs/ subversion/libsvn_subr/
subversion/svnmucc/ subversion/tests/libsvn_subr/ tools/dev/
tools/server-side/
Author: rhuijben
Date: Sat Dec 29 15:34:49 2012
New Revision: 1426773
URL: http://svn.apache.org/viewvc?rev=1426773&view=rev
Log:
Following up on r868009, replace the new invocations of apr_pool_* with
the equivalent svn_pool_* functions for code consistency.
As this is just a macro there are no functional changes.
* subversion/bindings/cxxhl/src/exception.cpp
* subversion/libsvn_client/merge.c
* subversion/libsvn_fs_fs/fs_fs.c
* subversion/libsvn_fs_fs/tree.c
* subversion/libsvn_subr/cache-membuffer.c
* subversion/libsvn_subr/cache_config.c
* subversion/libsvn_subr/mergeinfo.c
* subversion/svnmucc/svnmucc.c
* subversion/tests/libsvn_subr/named_atomic-test.c
* subversion/tests/svn_test_main.c
* tools/dev/fsfs-access-map.c
* tools/server-side/fsfs-reorg.c
* tools/server-side/fsfs-stats.c
(*): Use svn_pool_clear() and svn_pool_destroy() macros.
Modified:
subversion/trunk/subversion/bindings/cxxhl/src/exception.cpp
subversion/trunk/subversion/libsvn_client/merge.c
subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
subversion/trunk/subversion/libsvn_fs_fs/tree.c
subversion/trunk/subversion/libsvn_subr/cache-membuffer.c
subversion/trunk/subversion/libsvn_subr/cache_config.c
subversion/trunk/subversion/libsvn_subr/mergeinfo.c
subversion/trunk/subversion/svnmucc/svnmucc.c
subversion/trunk/subversion/tests/libsvn_subr/named_atomic-test.c
subversion/trunk/tools/dev/fsfs-access-map.c
subversion/trunk/tools/server-side/fsfs-reorg.c
subversion/trunk/tools/server-side/fsfs-stats.c
Modified: subversion/trunk/subversion/bindings/cxxhl/src/exception.cpp
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/cxxhl/src/exception.cpp?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/cxxhl/src/exception.cpp (original)
+++ subversion/trunk/subversion/bindings/cxxhl/src/exception.cpp Sat Dec 29 15:34:49 2012
@@ -309,11 +309,11 @@ error::message_list error::compile_messa
}
catch (...)
{
- apr_pool_destroy(pool);
+ svn_pool_destroy(pool);
throw;
}
- apr_pool_destroy(pool);
+ svn_pool_destroy(pool);
return ml;
}
Modified: subversion/trunk/subversion/libsvn_client/merge.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/merge.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/merge.c (original)
+++ subversion/trunk/subversion/libsvn_client/merge.c Sat Dec 29 15:34:49 2012
@@ -7348,7 +7348,7 @@ process_children_with_new_mergeinfo(merg
svn_mergeinfo_t path_explicit_mergeinfo;
svn_client__merge_path_t *new_child;
- apr_pool_clear(iterpool);
+ svn_pool_clear(iterpool);
/* Get the path's new explicit mergeinfo... */
SVN_ERR(svn_client__get_wc_mergeinfo(&path_explicit_mergeinfo, NULL,
@@ -8231,7 +8231,7 @@ record_mergeinfo_for_added_subtrees(
svn_mergeinfo_t parent_mergeinfo;
svn_mergeinfo_t added_path_mergeinfo;
- apr_pool_clear(iterpool);
+ svn_pool_clear(iterpool);
dir_abspath = svn_dirent_dirname(added_abspath, iterpool);
/* Grab the added path's explicit mergeinfo. */
Modified: subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c Sat Dec 29 15:34:49 2012
@@ -7219,7 +7219,7 @@ choose_delta_base(representation_t **rep
if (max_chain_length == 0)
*rep = NULL;
- apr_pool_destroy(sub_pool);
+ svn_pool_destroy(sub_pool);
}
/* verify that the reps don't form a degenerated '*/
Modified: subversion/trunk/subversion/libsvn_fs_fs/tree.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/tree.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/tree.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/tree.c Sat Dec 29 15:34:49 2012
@@ -319,7 +319,7 @@ auto_clear_dag_cache(fs_fs_dag_cache_t*
{
if (cache->first_lock == NULL && cache->insertions > BUCKET_COUNT)
{
- apr_pool_clear(cache->pool);
+ svn_pool_clear(cache->pool);
memset(cache->buckets, 0, sizeof(cache->buckets));
cache->insertions = 0;
Modified: subversion/trunk/subversion/libsvn_subr/cache-membuffer.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/cache-membuffer.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/cache-membuffer.c (original)
+++ subversion/trunk/subversion/libsvn_subr/cache-membuffer.c Sat Dec 29 15:34:49 2012
@@ -1973,7 +1973,7 @@ svn_membuffer_cache_get(void **value_p,
*/
if (++cache->alloc_counter > ALLOCATIONS_PER_POOL_CLEAR)
{
- apr_pool_clear(cache->pool);
+ svn_pool_clear(cache->pool);
cache->alloc_counter = 0;
}
@@ -2004,7 +2004,7 @@ svn_membuffer_cache_set(void *cache_void
cache->alloc_counter += 3;
if (cache->alloc_counter > ALLOCATIONS_PER_POOL_CLEAR)
{
- apr_pool_clear(cache->pool);
+ svn_pool_clear(cache->pool);
cache->alloc_counter = 0;
}
@@ -2062,7 +2062,7 @@ svn_membuffer_cache_get_partial(void **v
if (++cache->alloc_counter > ALLOCATIONS_PER_POOL_CLEAR)
{
- apr_pool_clear(cache->pool);
+ svn_pool_clear(cache->pool);
cache->alloc_counter = 0;
}
Modified: subversion/trunk/subversion/libsvn_subr/cache_config.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/cache_config.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/cache_config.c (original)
+++ subversion/trunk/subversion/libsvn_subr/cache_config.c Sat Dec 29 15:34:49 2012
@@ -131,7 +131,7 @@ svn_cache__get_global_membuffer_cache(vo
{
/* Memory and error cleanup */
svn_error_clear(err);
- apr_pool_destroy(pool);
+ svn_pool_destroy(pool);
/* Prevent future attempts to create the cache. However, an
* existing cache instance (see next comment) remains valid.
@@ -155,7 +155,7 @@ svn_cache__get_global_membuffer_cache(vo
*/
old_cache = apr_atomic_casptr((volatile void **)&cache, new_cache, NULL);
if (old_cache != NULL)
- apr_pool_destroy(pool);
+ svn_pool_destroy(pool);
}
return cache;
Modified: subversion/trunk/subversion/libsvn_subr/mergeinfo.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/mergeinfo.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/mergeinfo.c (original)
+++ subversion/trunk/subversion/libsvn_subr/mergeinfo.c Sat Dec 29 15:34:49 2012
@@ -1763,7 +1763,7 @@ svn_mergeinfo_merge2(svn_mergeinfo_t mer
{
SVN_ERR(svn_rangelist_merge2(target, to_insert, result_pool,
iterpool));
- apr_pool_clear(iterpool);
+ svn_pool_clear(iterpool);
}
else
apr_hash_set(mergeinfo, key, klen, to_insert);
Modified: subversion/trunk/subversion/svnmucc/svnmucc.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnmucc/svnmucc.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/subversion/svnmucc/svnmucc.c (original)
+++ subversion/trunk/subversion/svnmucc/svnmucc.c Sat Dec 29 15:34:49 2012
@@ -961,7 +961,7 @@ usage(apr_pool_t *pool, int exit_val)
" --no-auth-cache : do not cache authentication tokens\n"
" --version : print version information\n"),
stream, pool));
- apr_pool_destroy(pool);
+ svn_pool_destroy(pool);
exit(exit_val);
}
Modified: subversion/trunk/subversion/tests/libsvn_subr/named_atomic-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_subr/named_atomic-test.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_subr/named_atomic-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_subr/named_atomic-test.c Sat Dec 29 15:34:49 2012
@@ -178,17 +178,17 @@ init_test_shm(apr_pool_t *pool)
SVN_ERR(svn_named_atomic__get(&atomic, ns, ATOMIC_NAME "2", TRUE));
SVN_ERR(svn_named_atomic__write(NULL, 0, atomic));
- apr_pool_clear(scratch);
+ svn_pool_clear(scratch);
SVN_ERR(svn_atomic_namespace__create(&ns, name_namespace1, scratch));
SVN_ERR(svn_named_atomic__get(&atomic, ns, ATOMIC_NAME, TRUE));
SVN_ERR(svn_named_atomic__write(NULL, 0, atomic));
- apr_pool_clear(scratch);
+ svn_pool_clear(scratch);
SVN_ERR(svn_atomic_namespace__create(&ns, name_namespace2, scratch));
SVN_ERR(svn_named_atomic__get(&atomic, ns, ATOMIC_NAME, TRUE));
SVN_ERR(svn_named_atomic__write(NULL, 0, atomic));
- apr_pool_clear(scratch);
+ svn_pool_clear(scratch);
/* done */
@@ -256,7 +256,7 @@ APR_THREAD_FUNC test_thread(apr_thread_t
params->thread_count,
params->iterations,
pool);
- apr_pool_destroy(pool);
+ svn_pool_destroy(pool);
apr_thread_exit(thread, APR_SUCCESS);
return NULL;
@@ -401,7 +401,7 @@ calibrate_iterations(apr_pool_t *pool, i
SVN_ERR(run_procs(pool, TEST_PROC, count, calib_iterations));
taken = (double)(apr_time_now() - start);
- apr_pool_destroy(scratch);
+ svn_pool_destroy(scratch);
}
/* scale that to 1s */
Modified: subversion/trunk/tools/dev/fsfs-access-map.c
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dev/fsfs-access-map.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/tools/dev/fsfs-access-map.c (original)
+++ subversion/trunk/tools/dev/fsfs-access-map.c Sat Dec 29 15:34:49 2012
@@ -162,7 +162,7 @@ open_file(const char *name, int handle)
APR_READ | APR_BUFFERED, APR_OS_DEFAULT, sub_pool);
if (apr_file)
apr_file_info_get(&finfo, APR_FINFO_SIZE, apr_file);
- apr_pool_destroy(sub_pool);
+ svn_pool_destroy(sub_pool);
file = apr_pcalloc(pool, sizeof(*file));
file->name = apr_pstrdup(pool, name);
@@ -320,7 +320,7 @@ parse_file(apr_file_t *file)
break;
parse_line(line);
- apr_pool_clear(iter_pool);
+ svn_pool_clear(iter_pool);
}
while (line->len > 0);
}
Modified: subversion/trunk/tools/server-side/fsfs-reorg.c
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/server-side/fsfs-reorg.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/tools/server-side/fsfs-reorg.c (original)
+++ subversion/trunk/tools/server-side/fsfs-reorg.c Sat Dec 29 15:34:49 2012
@@ -1801,7 +1801,7 @@ read_pack_file(fs_fs_t *fs,
/* one more pack file processed */
print_progress(base);
- apr_pool_destroy(local_pool);
+ svn_pool_destroy(local_pool);
return SVN_NO_ERROR;
}
@@ -1867,7 +1867,7 @@ read_revision_file(fs_fs_t *fs,
if (revision % fs->max_files_per_dir == 0)
print_progress(revision);
- apr_pool_destroy(local_pool);
+ svn_pool_destroy(local_pool);
return SVN_NO_ERROR;
}
Modified: subversion/trunk/tools/server-side/fsfs-stats.c
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/server-side/fsfs-stats.c?rev=1426773&r1=1426772&r2=1426773&view=diff
==============================================================================
--- subversion/trunk/tools/server-side/fsfs-stats.c (original)
+++ subversion/trunk/tools/server-side/fsfs-stats.c Sat Dec 29 15:34:49 2012
@@ -1211,7 +1211,7 @@ read_pack_file(fs_fs_t *fs,
/* one more pack file processed */
print_progress(base);
- apr_pool_destroy(local_pool);
+ svn_pool_destroy(local_pool);
return SVN_NO_ERROR;
}
@@ -1267,7 +1267,7 @@ read_revision_file(fs_fs_t *fs,
if (revision % fs->max_files_per_dir == 0)
print_progress(revision);
- apr_pool_destroy(local_pool);
+ svn_pool_destroy(local_pool);
return SVN_NO_ERROR;
}