You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "klsince (via GitHub)" <gi...@apache.org> on 2023/08/08 22:08:20 UTC
[GitHub] [pinot] klsince commented on a diff in pull request #11299: QuerySummary exposing percentiles
klsince commented on code in PR #11299:
URL: https://github.com/apache/pinot/pull/11299#discussion_r1287731712
##########
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java:
##########
@@ -877,6 +877,10 @@ public void addValue(double value) {
}
}
+ public double getPercentile(double p){
Review Comment:
```suggestion
public double getPercentile(double p) {
```
##########
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java:
##########
@@ -944,6 +948,15 @@ public double getAvgClientTime() {
return _avgClientTime;
}
+ public double getPercentile(double p){
+ if(_statisticsList == null || _statisticsList.size() == 0)
Review Comment:
```suggestion
if (_statisticsList == null || _statisticsList.size() == 0) {
return 0.0;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org